Fix build command #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 26 26
===========================================
Files 1 1
Lines 70 70
===========================================
Hits 70 70
Continue to review full report at Codecov.
|
hendrikmaus
approved these changes
Mar 21, 2020
|
BTW @M165437 feel free to remove the robo lib and its file whenever it gets in the way; I do not think it provides any value. |
eugenefvdm
added a commit
to eugenefvdm/artisan-tool
that referenced
this pull request
Jun 18, 2020
Symfony 4 deprecated strings as commands. See here: hendrikmaus/drafter-php#13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moin Hendrik,
we need to update the build command to use the static factory method
Process::fromShellCommandline. Insymfony/processv4 the process constructor deprecated strings as commands and v5 doesn't support it at all anymore. This means removing support for v2 and v3 sincefromShellCommandlinewasn't available back then. OK with that?Note:
composer installin this package will loadsymfony/processv4 becauseconsolidation/roboisn't compatible with v5.Cheers!