tbcd: clean up peer and peermanager #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcopeereboom
changed the title
marcopeereboom
force-pushed
the
marco/peermanageragain
branch
from
0d816cb to
f00c034
Compare
joshuasing
requested changes
Oct 7, 2024
marcopeereboom
force-pushed
the
marco/peermanageragain
branch
from
93dd6ea to
382d103
Compare
joshuasing
requested changes
Oct 11, 2024
joshuasing
changed the title
joshuasing
changed the title
joshuasing
added
type: refactor
joshuasing
approved these changes
Oct 11, 2024
ClaytonNorthey92
approved these changes
Oct 11, 2024
web3cryptoguy
pushed a commit
to web3cryptoguy/heminetwork
that referenced
this pull request
Nov 1, 2024
* Start cleaning up peer and peermanager * Rewrite a new peer manager * Make new peer manager mostly work * Please linter * Add some prometheus crap * bring back reset clause * Make peer manager parallel * This seems to make providing seeds work correctly * Missing defer in mutex, thanks Joshua * Remove debug * Joshua suggestions * Catch up to go 1.23 to get nifty new tcp dial options and fix tests * Fix test * Bring back ping all peers * Deal with signals * fix seeding, don't run test that connects to testnet3 * fix make race; do not use same host and port for each test * Make it the same as bssd * Oops, forgot to commit this * sundry joshua nits * Fix error --------- Co-authored-by: ClaytonNorthey92 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Peer manager is currently a turd because it was part of the server struct and got adulterated over time.
Changes
Clean up this mess by making it a full citizen.
Fixes #214