bound height to 100 from canonical tip as to not have to scan large portion of index #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClaytonNorthey92
requested review from
jcvernaleo,
max-sanchez,
marcopeereboom and
joshuasing
github-actions
bot
added
the
area: bfg
joshuasing
approved these changes
Sep 11, 2024
web3cryptoguy
pushed a commit
to web3cryptoguy/heminetwork
that referenced
this pull request
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When getting the "effective height", we were not bounding the possible heights, this causes the query to scan over an entire index until it finds a height that is satisfactory to the rest of the query.
We use "effective height" in our "finality" calculation:
Finality = Min(100, (Canonical Tip Height - Effective Height - 9 + 1))
Since Finality cannot be more than 100, it is futile to look for an effective height that would be >= 100 blocks from the tip.
So we should only be concerned with effective heights >= tip - 100.
Changes
Bound the effective height calculation to 100 blocks from the tip to ensure that we don't scan over needless parts of the height index.
Important Note: if no results are returned, then the effective height gets "coalesced" to 0 which would result in and effective height of 0, and thus a finality of 100, which is expected.