cache bitcoin height from process btc block #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area: bfg
ClaytonNorthey92
requested review from
jcvernaleo,
max-sanchez,
marcopeereboom and
joshuasing
max-sanchez
approved these changes
Aug 28, 2024
ClaytonNorthey92
force-pushed
the
clayton/height-cache
branch
from
0114d42 to
21699ed
Compare
web3cryptoguy
pushed a commit
to web3cryptoguy/heminetwork
that referenced
this pull request
Nov 1, 2024
* cache bitcoin height from process btc block * skipping irrelevant test * check for notification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As of now, each time pop miner wants to mine they call
bfgapi.BitcoinInfoRequestto get the height. Bitcoin height doesn't change that often (not enough to be reaching out to the client in every single request at least).We have another goroutine that gets the height on a 5 second timer; piggy-back off of this to set a server-value of the btc height from the last success in this goroutine. This way, clients (i.e. pop miners) don't make a call to electrumx when getting bitcoin info.
Changes
use the result of another go routine's
btcClient.Heightto set a cached height value.this would be at most 5 seconds out-of-sync with electrumx