tbc: add block-by-hash command to RPC, use chainhash #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuasing
added
type: enhancement
marcopeereboom
approved these changes
Aug 26, 2024
marcopeereboom
approved these changes
Aug 26, 2024
joshuasing
force-pushed
the
joshua/tbc-block-by-hash
branch
from
dc346fe to
9ee0f38
Compare
ClaytonNorthey92
approved these changes
Aug 30, 2024
web3cryptoguy
pushed a commit
to web3cryptoguy/heminetwork
that referenced
this pull request
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
tbcapi-block-by-hashandtbcapi-block-by-hash-rawcommands to TBC RPC.Additionally, use
chainhash.Hashfor all hashes in RPC.Closes #219
Changes
tbcapi-block-by-hashandtbcapi-block-by-hash-rawcommands to TBC RPC, these commands can be used to retrieve blocks by their hash.chainhash.Hashinstead ofapi.ByteSlicefor hashes in RPC. This is a breaking change. Raw RPC calls must now provide hashes in display-order as well.UtxoasUTXOconsistently in thetbcapipackage. Initialisms should be all uppercase, per https://go.dev/wiki/CodeReviewComments#initialisms