Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: terminate with original signal unless useExit0 option passed #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rexxars
Copy link
Contributor

@rexxars rexxars commented Aug 9, 2024

BREAKING CHANGE: Process will now exit with the signal it received, instead of 0/1.

I believe it is more expected for a process to exit with the signal it was passed, rather than exiting with a generic 0 or 1. There are cases where a 0 exit code is wanted, so I added an option to allow for this behavior to continue. Note that I have inverted the default from what it previously was, thus this should be considered a breaking change.

BREAKING CHANGE: Process will now exit with the signal it received, instead of 0/1.

I believe it is more expected for a process to exit with the signal it was passed, rather than exiting with a generic 0 or 1. There are cases where a 0 exit code is wanted, so I added an option to allow for this behavior to continue. Note that I have inverted the default from what it previously was, thus this should be considered a breaking change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant