Robokop v5.0 #92
Merged
Robokop v5.0 #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaphetKG
commented
Nov 9, 2023
YaphetKG
commented
- New Robokop Graph
- CDE link fix
collection_action to action
mbacon-renci
reviewed
Nov 9, 2023
There was a problem hiding this comment.
All this looks fine, but I'm going to have to bring this over into the DugPipeline class at some point. What does the addition of line 391 do here? I just want to make sure I'm clear.
There was a problem hiding this comment.
total_items is one of the keys that is returned in the response. it looks something like
{ "total_items": 100
"dbgap" : {"elements" : [...]}
"cde" : {"elements" : [...]}
}
When doing the reduce on line 393 this causes problems since we are trying to gather element IDs and the total items key is an outlier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.