Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cde links 2 #331

Merged
merged 7 commits into from
Dec 4, 2023
Merged

Cde links 2 #331

merged 7 commits into from
Dec 4, 2023

Conversation

YaphetKG
Copy link
Contributor

@YaphetKG YaphetKG commented Nov 8, 2023

  • Fixes CDE link mapping
  • linkml v1.6.1 has issues pins it to last working version
  • check for making sure synonyms coming from graph nodes are list of strings.

@YaphetKG YaphetKG requested review from gaurav and braswent November 8, 2023 16:56
braswent
braswent approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@braswent braswent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the build again locally with python 3.10 and it works

@YaphetKG YaphetKG merged commit 2b09941 into develop Dec 4, 2023
8 checks passed
@YaphetKG YaphetKG deleted the cde-links-2 branch December 4, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braswent braswent braswent approved these changes

@gaurav gaurav Awaiting requested review from gaurav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YaphetKG @braswent