Added CORSMiddleware to allow Dug to make CORS requests #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gaurav , I think it might be solvable at the Ingress level. Which instance was doing so? |
|
but it doesn't hurt to have this . I wonder if the issue will still persist if we don't change the ingress thou |
YaphetKG
approved these changes
Nov 8, 2023
I ran into this while running Dug locally, so no ingress -- just running uvicorn directly with the backend running in Docker, I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working with Dug locally, I noticed that it doesn't provide CORS headers (presumably because it expects Kubernetes to do this). Since the API is intended to be used by anybody, I thought it wouldn't hurt to add CORSMiddleware to explicitly allow all direct API requests from browsers, but this is not my area of expertise, so please feel free to ignore this if this isn't ideal or if there is a better way to do this.