Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving topmed data #147

Merged
merged 3 commits into from
May 20, 2021
Merged

Improving topmed data #147

merged 3 commits into from
May 20, 2021

Conversation

cschreep
Copy link
Contributor

This change adds more info to the topmed variables file, so we have
user-friendly names for the variable name and variable description
fields.

Improving topmed data
b63bb5e 
This change adds more info to the topmed variables file, so we have
user-friendly names for the variable name and variable description
fields.
@cschreep cschreep requested a review from jcheadle-rti May 20, 2021 18:38
jcheadle-rti
jcheadle-rti suggested changes May 20, 2021
View reviewed changes
Copy link
Contributor

@jcheadle-rti jcheadle-rti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think you'll need to either change the file column header to 'variable_desc' or change the text in topmed_tag_parser.py (line 60, 61) to 'variable_description' instead of 'variable_desc'.

@cschreep
Copy link
Contributor Author

Good catch, see new commit. I added a test to cover it

@cschreep cschreep requested a review from jcheadle-rti May 20, 2021 18:55
jcheadle-rti
jcheadle-rti approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@jcheadle-rti jcheadle-rti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@cschreep cschreep merged commit 43b1455 into develop May 20, 2021
@cschreep cschreep deleted the feature/topmed-data-2.0 branch May 20, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcheadle-rti jcheadle-rti jcheadle-rti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cschreep @jcheadle-rti