-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consider gix instead of libgit2 #217
Comments
@vsiles what are your thoughts? Would you be able to pick this up? I think this has great value for our users (that can likely ditch some native libraries if we do this change) |
FWIW @j-baker you can disable the git feature for the time being |
I'm not familiar with these libs but that's a good way to get to know more of buffrs. I'll spend some time on it to assess if |
From what I understand of the usage of git2 in buffrs, it is mostly to check if the repo is "clean" (all files are either committed or ignored). gix and gix_status don't seem to be "there yet":
The current code would complain if some untracked files are present. We could walk the file system and check if there are some files that are not tracked and not ignored to achieve our goal, but I don't know if gix can give me information about ignored files. I'll try to check that and be back at you. EDIT: I just built gix which confirmed:
|
Completed in #220. |
libgit2 is a fairly minor dependency for buffrs, but at a fairly high cost for users. git is in the default featureset, so:
Instead of using libgit2 and all the extra cruft this entails, we could use gix instead, which I think supports the specific functionality we need. This would simplify the native dependency tree and reduce install times.
The text was updated successfully, but these errors were encountered: