Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignoring statuses of synched files under vendor when publishing #224

Closed
wants to merge 1 commit into from

Conversation

khanism
Copy link

@khanism khanism commented Feb 16, 2024

Regarding issue #200
This change adds some options to the check of the repository when publishing your Buffrs project.

When publishing, the statuses of the synched *.proto files under vendor are not included, avoiding the project being dirty as described in the issue

@mara-schulke
Copy link
Contributor

Hi @khanism, thank you for contributing!

Have you seen the work on #217 / 78740b1 ?

I think this issue still exists, but the way we check statuses for git has been changed 😊

If you can rebase and update your implementation I am more than happy to merge this, tysm!

@khanism
Copy link
Author

khanism commented Jul 5, 2024

@mara-schulke sorry for the long time of funkstille. Thanks for the remark, I'll update this so we can proceed with this PR :)

@khanism
Copy link
Author

khanism commented Jul 21, 2024

Closing because of updated fix in #263

@khanism khanism closed this Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants