buffrs publish refuses to publish when the proto/vendor/ is dirty
#200
Labels
complexity::low
Issues or ideas with a low implementation cost
component::cli
Everything related to the buffrs cli
priority::medium
This is not urgent, but we should do this.
type::fix
Comments
qsantos
changed the title
buffrs publish refuses to publishes when the proto/vendor/ is dirtybuffrs publish refuses to publish when the proto/vendor/ is dirty
|
I'm not sure if this was intended and if it is wanted to ignore/filter the messages that lead to buffrs complaining about dirty proto files under vendor. Anyhow since this was a quick one: #224 The PR does only include dirty statuses of the files actually being packaged. Should one wanted to add a subdirectory under proto (e.g. submodule that contains additional *.proto files) this solution wouldn't cover that but I'm not sure how much this is relevant as of now. |
|
I think we should get #224 over the line! |
mara-schulke
added
complexity::low
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When publishing, Buffrs populates the
proto/vendor/directory. If one attempts to publish again, Buffrs then complains that the repository is dirty. I think Buffrs should either:proto/vendor/before checking that the repository is cleanproto/vendor/when checking that the repository is cleanThe text was updated successfully, but these errors were encountered: