Skip to content

Commit

Permalink
flake check passes locally
Browse files Browse the repository at this point in the history
  • Loading branch information
edward.gokmen committed Feb 8, 2024
1 parent 7f1b01c commit 990d464
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 20 deletions.
21 changes: 19 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,16 @@ jobs:
- run: rustup update && rustup component add rustfmt
- run: cargo fmt --check --all

# TODO: get registry nixified so we set up an equivalent task in `Nix Buffrs CI`
clippy:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- run: rustup update && rustup component add clippy
- name: Install Protoc
uses: arduino/setup-protoc@v2
- uses: Swatinem/rust-cache@v2
- run: cargo clippy --all-targets --workspace -- -D warnings -D clippy::all

test:
runs-on: ubuntu-latest
steps:
Expand All @@ -37,7 +46,15 @@ jobs:
env:
RUST_BACKTRACE: 1

# TODO: get registry nixified so we set up an equivalent task in `Nix Buffrs CI`
deny:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- run: rustup update
- uses: Swatinem/rust-cache@v2
- run: cargo install cargo-deny || true
- run: cargo deny --workspace check

coverage:
runs-on: ubuntu-latest
steps:
Expand Down
18 changes: 0 additions & 18 deletions .nix/buffrs.nix
Original file line number Diff line number Diff line change
Expand Up @@ -28,24 +28,6 @@ in {
# Build the crate as part of `nix flake check` for convenience
buffrs = buffrs;

# Run clippy (and deny all warnings) on the crate source,
# again, resuing the dependency artifacts from above.
#
# Note that this is done as a separate derivation so that
# we can block the CI if there are issues here, but not
# prevent downstream consumers from building our crate by itself.
buffrs-clippy = craneLib.cargoClippy (commonArgs // {
inherit cargoArtifacts;
cargoClippyExtraArgs =
"--all-targets --workspace -- -D warnings -D clippy::all";
});

# Check formatting
buffrs-fmt = craneLib.cargoFmt {
inherit src;
cargoDenyExtraArgs = "--workspace check";
};

# Audit dependencies
buffrs-audit = craneLib.cargoAudit {
inherit src advisory-db;
Expand Down

0 comments on commit 990d464

Please sign in to comment.