Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sqlx to 0.8 #28

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Update sqlx to 0.8 #28

merged 1 commit into from
Jul 24, 2024

Conversation

ntrinquier
Copy link
Contributor

@ntrinquier ntrinquier commented Jul 23, 2024

sqlx 0.8 has quite a few breaking changes.

As far as we are concerned, the only compile-time breaking change is that the generic trait HasArguments has been replaced with a generic associated type in launchbadge/sqlx#2973, however this should be a no-op (the trait was only useful before GAT were introduced).

There are a few runtime breaking changes (eg. launchbadge/sqlx#2736 or launchbadge/sqlx#3064), but they seem very specific. Users should review the release notes above to check if anything apply to them in particular when upgrading.

@ntrinquier ntrinquier merged commit 82c0688 into main Jul 24, 2024
4 checks passed
@ntrinquier ntrinquier deleted the nvt/sqlx branch July 24, 2024 13:28
@cdbrkfxrpt
Copy link
Contributor

cdbrkfxrpt commented Jul 24, 2024

Would you mind providing a PR description that explains why the trait HasArguments is getting replaced with the Database one, and what (if any) breaking changes are introduced by sqlx 0.8?

edit: done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants