Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add getBeds query to api services #1147

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

DasProffi
Copy link
Member

Which issues does this pull request close?

closes #1103

[OPTIONAL] Give testing instructions to reviewers

@DasProffi DasProffi self-assigned this Dec 26, 2024
@DasProffi DasProffi requested a review from a team as a code owner December 26, 2024 10:13
@DasProffi DasProffi requested review from ChrisKulesza and felixevers and removed request for a team December 26, 2024 10:13
Copy link

cloudflare-workers-and-pages bot commented Dec 26, 2024

Deploying web with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2542e66
Status: ✅  Deploy successful!
Preview URL: https://e22ac1de.web-d91.pages.dev
Branch Preview URL: https://issue-1103-replace-getbedsby.web-d91.pages.dev

View logs

@MaxSchaefer
Copy link
Member

@DasProffi GetBedsByRoom was already removed? Checkout the offline service. Search GetBedsByRoom across the codebase.

@DasProffi
Copy link
Member Author

@DasProffi GetBedsByRoom was already removed? Checkout the offline service. Search GetBedsByRoom across the codebase.

Yes, therefore the new GetBedsQuery was implemented where roomId is an optional parameter to only query beds of a certain room.

The method still is overwritten in the BedOfflineServicePromiseClient in order to not forward it to an actual backend. I have marked it as deprecated, and we can remove it once the protos of services remove it.

@DasProffi DasProffi requested review from MaxSchaefer and removed request for ChrisKulesza January 9, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove usage of GetBedsByRooms and use GetBeds instead
2 participants