Issue-1126: Slice TaskDetailView more SRP like

[ChrisKulesza]

Preparatory work for the processing of Issue-1126

• move TaskDetailTranslation and translationData to separate TS file
• move TaskDetailViewSidebar to separate TS file
• move tasksDetails to TaskDetails
• move templateSidebar to TaskDetailViewTemplateSidebar
• move buttons to TaskDetailViewButtons

Motivation

• Structure code more legibly
• encapsulate technical differences between the individual components

Which issues does this pull request close?

none

[OPTIONAL] Give testing instructions to reviewers

[DasProffi]

The changes look good and improve the readability a lot (especially moving the subcomponents outside the TaskDetailView Component function into separate components). I am unsure whether using multiple files is the best solution in regard to finding the right component to change (due to similar naming, it is unclear which is the main file).

The previously used single file component design, makes sure only the main component is exported, while now every subcomponent is exported too and thus within the search space of the app, although its use is only inside the TaskDetailView.

Either 1) declare each subcomponent its own reusable component, or 2) follow the single file component design.

Changes for 1):

• make the props of the component public with an export and name them after the component
• use and declare individual translation within each component (in this case, I would see it as optional)

Changes for 2):
Move the subcomponents and Translations back inside the TaskDetailView.tsx and only export the TaskDetailView component.

Apart from that, fix the linting for the CI.

[ChrisKulesza]

The changes look good and improve the readability a lot (especially moving the subcomponents outside the TaskDetailView Component function into separate components). I am unsure whether using multiple files is the best solution in regard to finding the right component to change (due to similar naming, it is unclear which is the main file).

The previously used single file component design, makes sure only the main component is exported, while now every subcomponent is exported too and thus within the search space of the app, although its use is only inside the TaskDetailView.

Either 1) declare each subcomponent its own reusable component, or 2) follow the single file component design.

Changes for 1):

• make the props of the component public with an export and name them after the component
• use and declare individual translation within each component (in this case, I would see it as optional)

Changes for 2): Move the subcomponents and Translations back inside the TaskDetailView.tsx and only export the TaskDetailView component.

Apart from that, fix the linting for the CI.

Personally, I am flexible regarding how the Helpwave application is structured. In my day-to-day work, I am accustomed to organizing by features as well as following the SRP approach. If the preference here at Helpwave is to handle this with a large component approach, I am happy to implement it that way.

I have adapted this because working with a 450+ line component was a little difficult.

Could you please provide a clear direction? Thank you.

[DasProffi]

Personally, I am flexible regarding how the Helpwave application is structured. In my day-to-day work, I am accustomed to organizing by features as well as following the SRP approach. If the preference here at Helpwave is to handle this with a large component approach, I am happy to implement it that way.

I have adapted this because working with a 450+ line component was a little difficult.

Could you please provide a clear direction? Thank you.

Keep the subcomponents TaskDetailViewSidebar, TaskDetails, TaskDetailViewTemplateSidebar, TaskDetailViewButtons, but move them into a single file (approach 2 from my previous message). Only export the TaskDetailsView and have the TaskDetailTranslation also within that file.

[DasProffi]

Will be done in #1143