Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: centers the create button within the form in new task template #1119

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bathongor
Copy link
Contributor

@bathongor bathongor commented Nov 14, 2024

Which issues does this pull request close?

closes #1108 Spelling

@bathongor bathongor requested a review from a team as a code owner November 14, 2024 11:14
@bathongor bathongor requested review from felixevers and DasProffi and removed request for a team November 14, 2024 11:14
@MaxSchaefer MaxSchaefer self-requested a review November 14, 2024 12:53
@felixevers
Copy link
Member

@bathongor Please reference the right issue. This is not a spelling fix.

@felixevers felixevers marked this pull request as draft November 19, 2024 23:20
@bathongor bathongor marked this pull request as ready for review November 21, 2024 13:08
@felixevers
Copy link
Member

@MaxSchaefer is currently checking the CI issue.

@MaxSchaefer
Copy link
Member

Thats #1108 @bathongor?
I've updated the description :)
Thanks for your contribution.

@MaxSchaefer MaxSchaefer force-pushed the issue/1108-create-button-positioning branch from ae76513 to 3599286 Compare December 5, 2024 14:36
@MaxSchaefer
Copy link
Member

fyi: If approved, I will merge this with a bypass. We are currently not able to run the preview CI due to the external trigger.

Copy link
Member

@MaxSchaefer MaxSchaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bathongor thanks! But I guess @sophiafe was more interested in fixing the large blank space between the subtasks section and the create button.

We should keep the button to the right, as in every other create screen, and try to close the gap between the subtasks section and the create button :)

Bildschirmfoto 2024-12-05 um 4 13 58 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Task templates: "Create" button positioning
3 participants