Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bring organizations back home #124

Merged
merged 4 commits into from
Apr 10, 2023

Conversation

MaxSchaefer
Copy link
Member

@MaxSchaefer MaxSchaefer commented Apr 9, 2023

and remove the current user-svc which implemented Keycloak

Closes #105

@MaxSchaefer MaxSchaefer added enhancement New feature or request ADR-005: SSO labels Apr 9, 2023
@MaxSchaefer MaxSchaefer self-assigned this Apr 9, 2023
@MaxSchaefer MaxSchaefer linked an issue Apr 9, 2023 that may be closed by this pull request
and remove the current user-svc which implemented Keycloak
@MaxSchaefer MaxSchaefer force-pushed the issue/105-bring-organizations-back-home branch from 45ee5ff to be11eff Compare April 9, 2023 22:10
@MaxSchaefer MaxSchaefer marked this pull request as ready for review April 9, 2023 22:23
@MaxSchaefer MaxSchaefer requested a review from a team as a code owner April 9, 2023 22:23
@MaxSchaefer MaxSchaefer requested review from felixevers and FoseFx and removed request for a team April 9, 2023 22:23
Copy link
Member

@felixevers felixevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did'nt tested this pr but the changes are looking fine.
Because this pr is facing keycloak related stuff/issues we should consider @FoseFx opinion.

services/user-svc/internal/organization/organization.go Outdated Show resolved Hide resolved
services/user-svc/internal/organization/organization.go Outdated Show resolved Hide resolved
services/user-svc/internal/organization/organization.go Outdated Show resolved Hide resolved
services/user-svc/internal/organization/organization.go Outdated Show resolved Hide resolved
services/user-svc/internal/organization/organization.go Outdated Show resolved Hide resolved
services/user-svc/migrations/000001_init.up.sql Outdated Show resolved Hide resolved
services/user-svc/internal/organization/organization.go Outdated Show resolved Hide resolved
services/user-svc/internal/organization/organization.go Outdated Show resolved Hide resolved
@MaxSchaefer MaxSchaefer force-pushed the issue/105-bring-organizations-back-home branch from 6061dd8 to 67815e8 Compare April 10, 2023 10:36
@MaxSchaefer MaxSchaefer requested a review from FoseFx April 10, 2023 12:15
@MaxSchaefer MaxSchaefer merged commit 5618549 into main Apr 10, 2023
@MaxSchaefer MaxSchaefer deleted the issue/105-bring-organizations-back-home branch April 10, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADR-005: SSO enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring organizations back home
3 participants