-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bring organizations back home #124
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and remove the current user-svc which implemented Keycloak
MaxSchaefer
force-pushed
the
issue/105-bring-organizations-back-home
branch
from
April 9, 2023 22:10
45ee5ff
to
be11eff
Compare
MaxSchaefer
requested review from
felixevers and
FoseFx
and removed request for
a team
April 9, 2023 22:23
felixevers
approved these changes
Apr 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did'nt tested this pr but the changes are looking fine.
Because this pr is facing keycloak related stuff/issues we should consider @FoseFx opinion.
FoseFx
requested changes
Apr 10, 2023
Co-authored-by: Max Baumann <[email protected]>
MaxSchaefer
force-pushed
the
issue/105-bring-organizations-back-home
branch
from
April 10, 2023 10:36
6061dd8
to
67815e8
Compare
FoseFx
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and remove the current user-svc which implemented Keycloak
Closes #105