Skip to content

Commit

Permalink
chore: disarm versioning (#126)
Browse files Browse the repository at this point in the history
  • Loading branch information
MaxSchaefer authored Apr 10, 2023
1 parent 68c4926 commit d524afd
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 6 deletions.
7 changes: 4 additions & 3 deletions .github/workflows/buf.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ jobs:
steps:
- uses: actions/checkout@v3
- uses: bufbuild/buf-setup-action@v1
- uses: bufbuild/buf-breaking-action@v1
with:
against: 'https://github.com/${{ github.repository }}.git#branch=main'
# TODO (arm-versioning): Arm versioning by removing the comments of the following lines
# - uses: bufbuild/buf-breaking-action@v1
# with:
# against: 'https://github.com/${{ github.repository }}.git#branch=main'
9 changes: 6 additions & 3 deletions .github/workflows/publish-bufs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,13 @@ jobs:
fetch-depth: 2
- uses: bufbuild/buf-setup-action@v1
- uses: bufbuild/buf-lint-action@v1
- name: Check for illegal breakage
# TODO (arm-versioning): Arm versioning by remove the comment of ONLY the next line
# - name: Check for illegal breakage
# Only deletions are allowed. Breaking updates must happen in a new version of the package(s) in question.
# This is just a sanity check!
# For example it allows you to delete files from the latest version of a package (depending on context that might even be ok).
run: buf breaking --against '.git#ref=HEAD^' --error-format json | jq .type | if grep -v -q \"FILE_NO_DELETE\"; then exit 1; fi
# TODO (arm-versioning): Arm versioning by remove the comment of the next line
# run: buf breaking --against '.git#ref=HEAD^' --error-format json | jq .type | if grep -v -q \"FILE_NO_DELETE\"; then exit 1; fi
- name: Has breakage?
id: breaking
# We previously checked if any illegal breakage occurred, now check if we have breakage _at all_
Expand All @@ -50,7 +52,8 @@ jobs:
run: |
BUMP="patch"
if [ "$BREAKING" = "true" ]; then
BUMP="major"
# TODO (arm-versioning): Arm versioning by replacing the following "minor" with "major"
BUMP="minor"
elif [ "$NEW_PKG" = "true" ]; then
BUMP="minor"
else
Expand Down
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,9 @@ In the context of a service directory you should be able to use
```
to build the corresponding docker image as well.

## Temporary advises

### Arm versioning

[We disarmed the versioning for pre-production.](https://github.com/helpwave/services/issues/125).
To arm the versioning, search for "arm-versioning" in the codebase.

0 comments on commit d524afd

Please sign in to comment.