Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add open_live_handle function. Fix issue https://github.com/CoreSecur… #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ardikars
Copy link

@ardikars ardikars commented Apr 9, 2018

…ity/pcapy/issues/23

@dajose
Copy link
Contributor

dajose commented Apr 10, 2019

I was looking for support on pcapy for pcap_setdirection and I could find it only here.

Is there a way to set direction without this PR? @ardikars
what's the state of this PR?

@ardikars
Copy link
Author

I think pcapy doesn’t support pcap_setdirection() yet.

As libpcap documentation, pcap_setdirection isn't necessarily fully supported on all platforms. I think this function doesn't supported in Windows platform, so need to change the code on this PR like below:

#ifndef WIN32
    if (direction == 0) {
        pcap_setdirection(pt, PCAP_D_INOUT);
    } else if (direction == 1) {
        pcap_setdirection(pt, PCAP_D_IN);
    } else {
        pcap_setdirection(pt, PCAP_D_OUT);
    }
#endif

@dajose
Copy link
Contributor

dajose commented Apr 15, 2019

@ardikars I am trying to get #60 with only the setdirection feature... do you know who can I poke to get a review?

@ardikars
Copy link
Author

@dajose no idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants