Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dev Dependencies #16

Closed
wants to merge 1 commit into from
Closed

Update Dev Dependencies #16

wants to merge 1 commit into from

Conversation

ItsJonQ
Copy link
Contributor

@ItsJonQ ItsJonQ commented Mar 11, 2019

Update Dev Dependencies

This update bumps several dependencies to achieve the desired versions of
things related to Babel, ESLint, Jest, Storybook, and React.

Most of these updates come from @helpscout/[email protected].

Tested locally, and everything is working as expected, including Jest, Babel (build), Storybook, and Docz.

Webpack's version is capped at 4.28.4 due to an issue in docz

doczjs/docz#596

This update bumps several dependencies to achieve the desired versions of
things related to Babel, ESLint, Jest, Storybook, and React.

Most of these updates come from `@helpscout/[email protected]`.
@ItsJonQ ItsJonQ added the enhancement New feature or request label Mar 11, 2019
@ItsJonQ ItsJonQ self-assigned this Mar 11, 2019
@ItsJonQ ItsJonQ requested a review from knicklabs March 11, 2019 21:25
@@ -15,7 +15,7 @@
"test": "prestart && zero test --coverage",
"test:watch": "zero test --watch",
"version": "npm run build",
"release": "np --no-yarn",
"release": "zero release",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np is now part of zero :)

"prop-types": "latest",
"react": "16.6.3",
"react-dom": "16.6.3",
"react": "16.8.4",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... the one with hooks!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 229

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 226: 0.0%
Covered Lines: 250
Relevant Lines: 250

💛 - Coveralls

@ItsJonQ
Copy link
Contributor Author

ItsJonQ commented Mar 11, 2019

Arg... npm audit fix is causing docz to break. Why did I run that! lol

@ItsJonQ
Copy link
Contributor Author

ItsJonQ commented Mar 11, 2019

I... might have to try this again. So many issues with docz... ugh.

doczjs/docz#596
doczjs/docz#551

@ItsJonQ ItsJonQ closed this Mar 11, 2019
@knicklabs knicklabs deleted the update-dev-deps branch June 21, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants