-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: can-load guard #1008 #9551
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9551 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 227 227
Lines 4946 4946
Branches 1148 1148
=========================================
Hits 4946 4946 ☔ View full report in Codecov by Sentry. |
Hello @windmichael, I checked out the PR, for me it seems in line what is already done in the lib. |
d0eadc8
to
5139b0e
Compare
5139b0e
to
cae47b8
Compare
v14.13.1 has been released and contains a fix for the issue. Feel free to reopen the issue or to submit a new one if you meet any problems. |
I have added a new can-load.spec to verify that
NG_MOCKS_GUARDS
is working also with the canLoad guard.In addition I updated the docs to have link this the can-load.spec instaed of the can-match.spec.
Hope this PR helps.
Thanks for the good work. I really like using ng-mocks.
fixes #9835