Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: can-load guard #1008 #9551

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

windmichael
Copy link

@windmichael windmichael commented Jul 25, 2024

I have added a new can-load.spec to verify that NG_MOCKS_GUARDS is working also with the canLoad guard.
In addition I updated the docs to have link this the can-load.spec instaed of the can-match.spec.

Hope this PR helps.
Thanks for the good work. I really like using ng-mocks.

fixes #9835

@windmichael windmichael requested a review from satanTime as a code owner July 25, 2024 19:46
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (fd98e37) to head (cae47b8).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #9551   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          227       227           
  Lines         4946      4946           
  Branches      1148      1148           
=========================================
  Hits          4946      4946           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JsantosDK
Copy link
Contributor

Hello @windmichael, I checked out the PR, for me it seems in line what is already done in the lib.
Pointed out some sentence stuff, if you could correct that would be great.
Also, did you test this with Angular 18? Asking because not sure that the way you trigger the navigation will work in that version.

@satanTime satanTime linked an issue Aug 25, 2024 that may be closed by this pull request
@satanTime satanTime enabled auto-merge August 25, 2024 13:06
@satanTime satanTime force-pushed the docs/can-load-guard branch from 5139b0e to cae47b8 Compare August 25, 2024 13:09
@satanTime satanTime merged commit 2ccc605 into help-me-mom:master Aug 25, 2024
6 checks passed
@windmichael windmichael deleted the docs/can-load-guard branch August 25, 2024 13:30
@satanTime
Copy link
Member

v14.13.1 has been released and contains a fix for the issue. Feel free to reopen the issue or to submit a new one if you meet any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: CanLoad coverage
3 participants