Add support for UniqueId selectors #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcphilipp
reviewed
Sep 26, 2022
giurim
reviewed
Sep 26, 2022
src/main/java/co/helmethair/scalatest/descriptor/ScalatestDescriptor.java
Show resolved
Hide resolved
giurim
reviewed
Sep 27, 2022
alextu
force-pushed
the
atual/uniqueid
branch
from
eeb12ab to
c299772
Compare
giurim
reviewed
Sep 27, 2022
alextu
force-pushed
the
atual/uniqueid
branch
from
c299772 to
e5c6e6e
Compare
|
One more thing: I cannot update your branch, main is ahead and cannot merge until it is up to date. |
giurim
previously approved these changes
Sep 27, 2022
Will do, could you also wait for @marcphilipp's approval before merging? |
|
Sure thing, happy to have another set of eyes on it.
…On Tue, Sep 27, 2022, 15:27 Alexis Tual ***@***.***> wrote:
One more thing: I cannot update your branch, main is ahead and cannot
merge until it is up to date.
Will do, could you also wait for @marcphilipp
<https://github.com/marcphilipp>'s approval before merging?
—
Reply to this email directly, view it on GitHub
<#91 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADST4FM7WEM2UTF64HF2MOTWALY33ANCNFSM6AAAAAAQV4IK7U>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
alextu
force-pushed
the
atual/uniqueid
branch
from
e5c6e6e to
47c40fc
Compare
marcphilipp
previously approved these changes
Sep 27, 2022
alextu
force-pushed
the
atual/uniqueid
branch
from
47c40fc to
43df8db
Compare
|
@giurim I've rebased on origin/main and Marc reviewed it, you should be able to merge |
giurim
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #88 by enabling discovery by UniqueIds.
For example, given a selector
[engine:scalatest]/[suite:tests.SomeTest], it should discoverSomeTest.But given
[engine:scalatest]/[suite:tests.SomeTest]/[some method], it will still discoverSomeTestand execute all its tests method.Supporting selecting only the provided method would require some refactoring in the
Discoveryclass.