show monocular version in ui #337
Conversation
.travis.yml
Outdated
| @@ -19,6 +19,10 @@ before_install: | |||
| install: | |||
| - make -C src/api bootstrap | |||
| - make -C src/ui install | |||
| - | | |||
| if [[ -n "$TRAVIS_TAG" ]]; then | |||
There was a problem hiding this comment.
cc @sameersbn this will work as intended, right?
There was a problem hiding this comment.
I think you meant to write
make -C src/ui VERSION=$TRAVIS_TAG set-version
There was a problem hiding this comment.
As an aside, if you want to git rid of the inline bash from travis, then you could replace the VERSION ?= dev assignment in the Makefile with.
ifeq "$(VERSION)" ""
override VERSION = dev
endifThere was a problem hiding this comment.
oops good catch, thanks
.travis.yml
Outdated
| @@ -19,6 +19,10 @@ before_install: | |||
| install: | |||
| - make -C src/api bootstrap | |||
| - make -C src/ui install | |||
| - | | |||
| if [[ -n "$TRAVIS_TAG" ]]; then | |||
There was a problem hiding this comment.
As an aside, if you want to git rid of the inline bash from travis, then you could replace the VERSION ?= dev assignment in the Makefile with.
ifeq "$(VERSION)" ""
override VERSION = dev
endif
|
@sameersbn PTAL! |
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
=======================================
Coverage 88.41% 88.41%
=======================================
Files 17 17
Lines 820 820
=======================================
Hits 725 725
Misses 61 61
Partials 34 34Continue to review full report at Codecov.
|
closes #316