-
Notifications
You must be signed in to change notification settings - Fork 220
Conversation
@kemcake tests seems to be failing because the
|
Codecov Report
@@ Coverage Diff @@
## master #303 +/- ##
=========================================
Coverage ? 90.42%
=========================================
Files ? 18
Lines ? 971
Branches ? 0
=========================================
Hits ? 878
Misses ? 62
Partials ? 31 Continue to review full report at Codecov.
|
@@ -3,7 +3,7 @@ version: '2' | |||
services: | |||
ui: | |||
tty: true # Enables debugging capabilities when attached to this container. | |||
image: bitnami/angular:2.0.0 | |||
image: bitnami/angular:1.1.3-r0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to downgrade the version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is my fault, it's not actually a downgrade but I tagged it with the image version (as we normally do with containers) rather than the angular version. We should probably bump the image version to 2.0.0 to avoid the confusion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks for the clarification
"@angular/core": "2.4.3", | ||
"@angular/forms": "2.4.3", | ||
"@angular/http": "2.4.3", | ||
"@angular/animations": "^4.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any break-change between angular version 2 and 4? I think this is a huge change. I found some break-changes between minor versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may sounds huge, but they actually change from 2 to 4 for "semantic versioning", and the changes are not that important. Plus, it's "backwards compatible with 2.x.x" for most cases.
source: https://angularjs.blogspot.it/2017/03/angular-400-now-available.html
// Set tags | ||
this.metaService.setTitle(content.title, suffix); | ||
this.metaService.setTitle(content.title); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does ng2-meta
and ngx-meta
share the same API?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it was actually based on ng2-meta, but ng2-meta is not active anymore.
|
This reverts commit 4a42192.
@kemcake I've reverted this for now as we figure out what the issue is, unfortunately #310 doesn't fix this. This is the error I'm getting (with #310 checked out):
|
Some dependencies needed to be updated, this also add support for node v8 / npm v5
cc @prydonius @Angelmmiguel