Skip to content
This repository has been archived by the owner on Jul 16, 2021. It is now read-only.

[ui] Update dependencies #303

Merged
merged 11 commits into from
Jul 12, 2017
Merged

[ui] Update dependencies #303

merged 11 commits into from
Jul 12, 2017

Conversation

remstos
Copy link
Contributor

@remstos remstos commented Jun 29, 2017

Some dependencies needed to be updated, this also add support for node v8 / npm v5

cc @prydonius @Angelmmiguel

@prydonius
Copy link
Member

@kemcake tests seems to be failing because the ng build command has changed options:

npm run compile-aot
> [email protected] compile-aot /home/travis/build/helm/monocular/src/ui
> ng build --prod --aot --progress=false -o rootfs/dist
The option '--o' is not registered with the build command. Run `ng build --help` for a list of supported options.

@codecov-io
Copy link

codecov-io commented Jul 3, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@8364dab). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #303   +/-   ##
=========================================
  Coverage          ?   90.42%           
=========================================
  Files             ?       18           
  Lines             ?      971           
  Branches          ?        0           
=========================================
  Hits              ?      878           
  Misses            ?       62           
  Partials          ?       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8364dab...a9f06eb. Read the comment docs.

@@ -3,7 +3,7 @@ version: '2'
services:
ui:
tty: true # Enables debugging capabilities when attached to this container.
image: bitnami/angular:2.0.0
image: bitnami/angular:1.1.3-r0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to downgrade the version?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my fault, it's not actually a downgrade but I tagged it with the image version (as we normally do with containers) rather than the angular version. We should probably bump the image version to 2.0.0 to avoid the confusion

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for the clarification

"@angular/core": "2.4.3",
"@angular/forms": "2.4.3",
"@angular/http": "2.4.3",
"@angular/animations": "^4.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any break-change between angular version 2 and 4? I think this is a huge change. I found some break-changes between minor versions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may sounds huge, but they actually change from 2 to 4 for "semantic versioning", and the changes are not that important. Plus, it's "backwards compatible with 2.x.x" for most cases.
source: https://angularjs.blogspot.it/2017/03/angular-400-now-available.html

// Set tags
this.metaService.setTitle(content.title, suffix);
this.metaService.setTitle(content.title);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does ng2-meta and ngx-meta share the same API?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it was actually based on ng2-meta, but ng2-meta is not active anymore.

@remstos
Copy link
Contributor Author

remstos commented Jul 11, 2017

+7,674 lines, mostly because of package-lock.json 👎

@prydonius prydonius merged commit 4a42192 into helm:master Jul 12, 2017
prydonius added a commit that referenced this pull request Jul 17, 2017
@prydonius
Copy link
Member

@kemcake I've reverted this for now as we figure out what the issue is, unfortunately #310 doesn't fix this.

This is the error I'm getting (with #310 checked out):

dc up ui
Recreating monocular_ui_1 ...
Recreating monocular_ui_1 ... done
Attaching to monocular_ui_1
ui_1   | 0mWelcome to the Bitnami angular container
ui_1   | Subscribe to project updates by watching https://github.com/bitnami/bitnami-docker-angular
ui_1   | Submit issues and feature requests at https://github.com/bitnami/bitnami-docker-angular/issues
ui_1   | Send us your feedback at [email protected]
ui_1   |
ui_1   | Copying node_modules directory
ui_1   | Installing/Updating Angular dependencies (npm)
added 151 packages, removed 264 packages, updated 57 packages and moved 23 packages in 253.092s
ui_1   | Dependencies updated
ui_1   | Initialization finished
ui_1   | Cannot find module 'loader-runner'
ui_1   | Error: Cannot find module 'loader-runner'
ui_1   |     at Function.Module._resolveFilename (module.js:485:15)
ui_1   |     at Function.Module._load (module.js:437:25)
ui_1   |     at Module.require (module.js:513:17)
ui_1   |     at require (internal/module.js:11:18)
ui_1   |     at Object.<anonymous> (/app/node_modules/@angular/cli/node_modules/webpack/lib/NormalModule.js:25:20)
ui_1   |     at Module._compile (module.js:569:30)
ui_1   |     at Object.Module._extensions..js (module.js:580:10)
ui_1   |     at Module.load (module.js:503:32)
ui_1   |     at tryModuleLoad (module.js:466:12)
ui_1   |     at Function.Module._load (module.js:458:3)

prydonius added a commit that referenced this pull request Jul 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants