Skip to content
This repository has been archived by the owner on Jul 16, 2021. It is now read-only.

Fixes parsing of service URL #275

Merged
merged 1 commit into from
Jun 16, 2017

Conversation

prydonius
Copy link
Member

@prydonius prydonius commented Jun 15, 2017

The original expression was parsing had INT_PORT:EXT_PORT/TCP, but it
seems this has changed to EXT_PORT:INT_PORT/TCP.

Fixes #246

@prydonius prydonius requested a review from Angelmmiguel June 15, 2017 19:20
@prydonius
Copy link
Member Author

screen shot 2017-06-15 at 21 22 05

@codecov-io
Copy link

Codecov Report

Merging #275 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #275   +/-   ##
=======================================
  Coverage   90.35%   90.35%           
=======================================
  Files          18       18           
  Lines         964      964           
=======================================
  Hits          871      871           
  Misses         62       62           
  Partials       31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebbe797...33915fd. Read the comment docs.

@prydonius prydonius merged commit 2e0af23 into helm:master Jun 16, 2017
@prydonius prydonius deleted the 246-fix-generated-link branch June 16, 2017 09:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants