This repository has been archived by the owner on Jul 16, 2021. It is now read-only.
Improve tiller communication to support RBAC #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removes querying the K8S API to check if tiller is installed - removes attempt to install tiller (this should be handled by the cluster admin as it requires setting up service accounts and roles in RBAC environments) - only accesses the K8S API if tillerPortForward setting is enabled
Codecov Report
@@ Coverage Diff @@
## master #267 +/- ##
=======================================
Coverage 90.14% 90.14%
=======================================
Files 18 18
Lines 944 944
=======================================
Hits 851 851
Misses 62 62
Partials 31 31Continue to review full report at Codecov.
|
mkmik
approved these changes
Jun 7, 2017
src/api/data/helm/client/client.go
Outdated
| client := helm.NewClient(helm.Host(tillerHost)) | ||
| // test connection | ||
| if _, err := client.GetVersion(); err != nil { | ||
| return nil, errors.New("Failed to connect to Tiller, are you sure it is installed?") |
There was a problem hiding this comment.
error strings should not be capitalized. Read more about it in https://github.com/golang/go/wiki/CodeReviewComments#error-strings
|
thank you for the review @mmikulicic!! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cluster admin as it requires setting up service accounts and roles in
RBAC environments)