This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
Add Replace_Dots option to fluent-bit elasticsearch output #8659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm-bot
added
Contribution Allowed
k8s-ci-robot
added
the
needs-ok-to-test
|
/lgtm |
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
please bump chart version to 0.13.2 |
helm-bot
added
size/XS
donbowman
force-pushed
the
fluentbit-replace-dots
branch
from
83592ac to
dc91b93
Compare
helm-bot
added
Contribution Allowed
donbowman
force-pushed
the
fluentbit-replace-dots
branch
from
dc91b93 to
a84dd40
Compare
helm-bot
added
size/XS
|
/lgtm |
|
/assign @foxish |
|
/assign @davidkarlsen |
|
New changes are detected. LGTM label has been removed. |
helm-bot
added
size/XS
donbowman
force-pushed
the
fluentbit-replace-dots
branch
from
73c5204 to
d3d4ed8
Compare
helm-bot
added
size/XS
This addresses fluent/fluent-bit#854. Make 'Replace_Dots' settable for fluent-bit elasticsearch output, and default to 'On'. Signed-off-by: Don Bowman <[email protected]>
Signed-off-by: Don Bowman <[email protected]>
donbowman
force-pushed
the
fluentbit-replace-dots
branch
from
d3d4ed8 to
b860cd5
Compare
helm-bot
added
size/XS
Signed-off-by: Don Bowman <[email protected]>
helm-bot
added
size/XS
This was referenced Nov 5, 2018
Signed-off-by: Don Bowman <[email protected]>
helm-bot
added
size/XS
|
is there anything more I need to do here? |
|
@rimusz i need the /lgtm etc again since after bumping the chart version to match master it shows as a change. |
|
coming back to this, @rimusz @davidkarlsen @foxish I'm not sure what more is needed from me. |
|
ping? hello? |
|
lgtm |
Signed-off-by: Don Bowman <[email protected]>
helm-bot
added
size/XS
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: donbowman, rimusz If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I believe #9008 incorporates this, closing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses fluent/fluent-bit#854.
Make 'Replace_Dots' settable for fluent-bit elasticsearch
output, and default to 'On'.
Signed-off-by: Don Bowman [email protected]
What this PR does / why we need it:
Elasticsearch does not allow a leaf to be both 'text' and 'object'. In Kubernetes, labels + annotations can be of the format 'app' or 'app.kubernetes.io/foo', which confuses it. Fluent-bit has an option 'Replace_Dots' which should be settable (and default on).
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)fluent/fluent-bit#854
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]