This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/rabbitmq] Fix chart not being upgradable by removing mutable label from VolumeClaimTemplate #7687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ey-bot
added
the
Contribution Allowed
k8s-ci-robot
added
the
needs-ok-to-test
scottrigby
suggested changes
Sep 12, 2018
There was a problem hiding this comment.
We'll also need to update the README with any manual steps to upgrade to this breaking change. See #5657
ey-bot
removed
the
Contribution Allowed
|
Waiting for #5657 to be settled before updating this PR. |
ey-bot
added
the
Contribution Allowed
|
/hold However, I still appreciate any other feedback not related to this "document how to upgrade" thing. |
k8s-ci-robot
added
the
do-not-merge/hold
…by removing 'chart' label from spec.selector or spec.VolumeClaimTemplate. See #7680. Signed-off-by: Cédric de Saint Martin <[email protected]>
ey-bot
added
the
Contribution Allowed
desaintmartin
changed the title
|
/unhold |
|
Thanks for the update @desaintmartin |
|
/ok-to-test |
k8s-ci-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: desaintmartin, juan131 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
jicowan
pushed a commit
to jicowan/charts
that referenced
this pull request
Oct 2, 2018
…by removing 'chart' label from spec.selector or spec.VolumeClaimTemplate. (helm#7687) See helm#7680. Signed-off-by: Cédric de Saint Martin <[email protected]> Signed-off-by: jenkin-x <[email protected]>
intelfx
pushed a commit
to intelfx/charts
that referenced
this pull request
Oct 19, 2018
…by removing 'chart' label from spec.selector or spec.VolumeClaimTemplate. (helm#7687) See helm#7680. Signed-off-by: Cédric de Saint Martin <[email protected]>
Jnig
pushed a commit
to Jnig/charts
that referenced
this pull request
Nov 13, 2018
…by removing 'chart' label from spec.selector or spec.VolumeClaimTemplate. (helm#7687) See helm#7680. Signed-off-by: Cédric de Saint Martin <[email protected]> Signed-off-by: Jakob Niggel <[email protected]>
wgiddens
pushed a commit
to wgiddens/charts
that referenced
this pull request
Jan 18, 2019
…by removing 'chart' label from spec.selector or spec.VolumeClaimTemplate. (helm#7687) See helm#7680. Signed-off-by: Cédric de Saint Martin <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Major version bump: Fix chart not being upgradable by removing 'chart' label from spec.VolumeClaimTemplate.
Special notes for your reviewer:
See
#7680#7803.cc @prydonius @tompizmor @sameersbn @carrodher @juan131