Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[NEW] kube-lego #397

Merged
merged 5 commits into from
Feb 1, 2017
Merged

[NEW] kube-lego #397

merged 5 commits into from
Feb 1, 2017

Conversation

mgoodness
Copy link
Contributor

This is a stand-alone chart for kube-lego, as mentioned and (briefly) discussed in #385. Should be generic enough to be used with nginx-ingress (PR coming soon) or the GCLB.

@jackzampolin

Michael Goodness added 2 commits January 14, 2017 01:12
* Stand-alone chart for use with nginx or GCLB
* env values in quotes
@k8s-ci-robot
Copy link
Contributor

Hi @mgoodness. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 14, 2017
@mgoodness mgoodness mentioned this pull request Jan 14, 2017
* Delete kube-lego-nginx service on release deletion
* Updated 'app' label & container name
* Improved values documentation
@viglesiasce
Copy link
Contributor

Tested this over the weekend without any issues.

@viglesiasce
Copy link
Contributor

@k8s-bot e2e test this

@jackzampolin
Copy link
Contributor

Tested this with #399. LGTM

@viglesiasce
Copy link
Contributor

@k8s-bot e2e test this

@mgoodness
Copy link
Contributor Author

I suspect there's a problem with the post-delete hook I introduced in my last commit. Let me try something...

@mgoodness
Copy link
Contributor Author

mgoodness commented Jan 31, 2017

My fix for now is not to clean up. kube-lego creates its own secret, ingress, and service, but only when it finds an externally-created ingress to handle. The e2e runs in an isolated environment, so those resources are never created and the cleanup jobs are never able to delete them. The jobs just keep running until Jenkins times out. Best I can do is add a activeDeadlineSeconds to each job, but that also looks like a failure.

Cleanup in this case might best be done by the application itself.

Let's see if I can have...
@k8s-bot e2e test this

Edit: Ha! Guess not.

@k8s-ci-robot
Copy link
Contributor

@mgoodness: you can't request testing unless you are a kubernetes member.

In response to this comment:

My fix for now is not to clean up. kube-lego creates its own secret, ingress, and service, but only when it finds an externally-created ingress to handle. The e2e runs in an isolated environment, so those resources are never created and the cleanup jobs are never able to delete them. The jobs just keep running until Jenkins times out. Best I can do is add a activeDeadlineSeconds to each job, but that also looks like a failure.

Cleanup in this case might best be done by the application itself.

Let's see if I can have...
@k8s-bot e2e test this

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@viglesiasce
Copy link
Contributor

@k8s-bot e2e test this

@viglesiasce
Copy link
Contributor

@mgoodness worked this time around

@prydonius prydonius merged commit a76cf96 into helm:master Feb 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. code reviewed lgtm Indicates that a PR is ready to be merged. UX reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants