-
Notifications
You must be signed in to change notification settings - Fork 16.8k
Conversation
* Stand-alone chart for use with nginx or GCLB
* env values in quotes
Hi @mgoodness. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
* Delete kube-lego-nginx service on release deletion * Updated 'app' label & container name * Improved values documentation
Tested this over the weekend without any issues. |
@k8s-bot e2e test this |
Tested this with #399. LGTM |
@k8s-bot e2e test this |
I suspect there's a problem with the post-delete hook I introduced in my last commit. Let me try something... |
My fix for now is not to clean up. kube-lego creates its own secret, ingress, and service, but only when it finds an externally-created ingress to handle. The e2e runs in an isolated environment, so those resources are never created and the cleanup jobs are never able to delete them. The jobs just keep running until Jenkins times out. Best I can do is add a Cleanup in this case might best be done by the application itself. Let's see if I can have... Edit: Ha! Guess not. |
@mgoodness: you can't request testing unless you are a kubernetes member. In response to this comment:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@k8s-bot e2e test this |
@mgoodness worked this time around |
This is a stand-alone chart for kube-lego, as mentioned and (briefly) discussed in #385. Should be generic enough to be used with nginx-ingress (PR coming soon) or the GCLB.
@jackzampolin