-
Notifications
You must be signed in to change notification settings - Fork 16.8k
Conversation
Signed-off-by: Mathew Wicks <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
Hi @thesuperzapper. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@gsemet can you please review? (Sorry its a big one) |
Thanks a lot for this pull request, nothing to add it looks great :) /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gsemet, thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We're hitting an error now in our CI but I think this is an issue with Helm itself...?
|
This PR adds a bunch of features, see UPGRADE.md for more information.
The most significant change is a refactor of the
templates/
folder, (I have grouped together the YAML from each component).Checklist
[stable/mychartname]
)