This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/prometheus] Document in README and Values "enableServiceLinks" #23346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xtigyro <[email protected]>
Signed-off-by: Xtigyro <[email protected]>
Signed-off-by: Xtigyro <[email protected]>
Signed-off-by: Xtigyro <[email protected]>
Signed-off-by: Xtigyro <[email protected]>
helm-bot
added
Contribution Allowed
k8s-ci-robot
added
the
approved
zanhsieh
approved these changes
Jul 26, 2020
|
/assign |
Signed-off-by: Xtigyro <[email protected]>
zanhsieh
approved these changes
Jul 27, 2020
|
/lgtm |
|
@Xtigyro: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Xtigyro, zanhsieh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
li-adrienloiseau
pushed a commit
to li-adrienloiseau/charts
that referenced
this pull request
Jul 29, 2020
helm#23346) * Values file comment fix. Document enableServiceLinks. Signed-off-by: Xtigyro <[email protected]> * document fix for enableServiceLinks Signed-off-by: Xtigyro <[email protected]> * small typo fix Signed-off-by: Xtigyro <[email protected]> * better explanation for EnableServiceLinks Signed-off-by: Xtigyro <[email protected]> * bump chart ver. Signed-off-by: Xtigyro <[email protected]> * clearer EnableServiceLinks warning Signed-off-by: Xtigyro <[email protected]> Signed-off-by: Adrien Loiseau <[email protected]>
mmingorance-dh
pushed a commit
to mmingorance-dh/charts
that referenced
this pull request
Aug 28, 2020
helm#23346) * Values file comment fix. Document enableServiceLinks. Signed-off-by: Xtigyro <[email protected]> * document fix for enableServiceLinks Signed-off-by: Xtigyro <[email protected]> * small typo fix Signed-off-by: Xtigyro <[email protected]> * better explanation for EnableServiceLinks Signed-off-by: Xtigyro <[email protected]> * bump chart ver. Signed-off-by: Xtigyro <[email protected]> * clearer EnableServiceLinks warning Signed-off-by: Xtigyro <[email protected]> Signed-off-by: Miguel Mingorance <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a new chart
No.
What this PR does / why we need it:
README.mdandvalues.yamlenableServiceLinksfor Prometheus server pods.Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname])