Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[incubator/druid] an invalid default value at midddleManager.config.druid_indexer_runner_javaOptsArray (#23312) #23313

Merged
merged 1 commit into from
Jul 28, 2020
Merged

[incubator/druid] an invalid default value at midddleManager.config.druid_indexer_runner_javaOptsArray (#23312) #23313

merged 1 commit into from
Jul 28, 2020

Conversation

youngwookim
Copy link
Contributor

@youngwookim youngwookim commented Jul 23, 2020 •
edited
Loading

Which issue this PR fixes

(#23312)

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 23, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @youngwookim. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 23, 2020
@youngwookim
Copy link
Contributor Author

/assign @maver1ck

@maver1ck
Copy link
Collaborator

@youngwookim
Please bump chart version

@youngwookim
Copy link
Contributor Author

youngwookim commented Jul 24, 2020 •
edited
Loading

@maver1ck
Addressed your comment. Bumped up chart version to 0.2.9 from 0.2.8

@maver1ck
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 24, 2020
@maver1ck
Copy link
Collaborator

@youngwookim
please check test result

@youngwookim
[incubator/druid] an invalid default value at midddleManager.config.d…
4b488cb 
…ruid_indexer_runner_javaOptsArray (helm#23312)

Signed-off-by: Youngwoo Kim <[email protected]>
@youngwookim
Copy link
Contributor Author

youngwookim commented Jul 25, 2020 •
edited
Loading

@maver1ck Fixed the test failure. Bumped up chart version to 0.2.10

@youngwookim
Copy link
Contributor Author

/retest

@maver1ck
Copy link
Collaborator

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maver1ck, youngwookim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Jul 28, 2020
@k8s-ci-robot k8s-ci-robot merged commit 8e6b29a into helm:master Jul 28, 2020
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
@youngwookim @li-adrienloiseau
[incubator/druid] an invalid default value at midddleManager.config.d…
31a04c4 
…ruid_indexer_runner_javaOptsArray (helm#23312) (helm#23313)

Signed-off-by: Youngwoo Kim <[email protected]>
Signed-off-by: Adrien Loiseau <[email protected]>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@youngwookim
[incubator/druid] an invalid default value at midddleManager.config.d…
2794e52 
…ruid_indexer_runner_javaOptsArray (helm#23312) (helm#23313)

Signed-off-by: Youngwoo Kim <[email protected]>
Signed-off-by: Miguel Mingorance <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maver1ck maver1ck Awaiting requested review from maver1ck

Assignees

@maver1ck maver1ck

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@youngwookim @k8s-ci-robot @maver1ck @helm-bot