Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/prometheus] Disable "enableServiceLinks" on Kubernetes prior 1.13 #23299

Merged
merged 2 commits into from
Jul 22, 2020
Merged

Conversation

atkrad
Copy link
Contributor

@atkrad atkrad commented Jul 22, 2020

What this PR does / why we need it:

I use K8s prior 1.13 when I've applied the Prometheus statefulset this error occurred:
Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: ValidationError(StatefulSet.spec.template.spec): unknown field "enableServiceLinks" in io.k8s.api.core.v1.PodSpec
because the field doesn't available for prior version 1.13

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Jul 22, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @atkrad. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 22, 2020
@zanhsieh
Copy link
Collaborator

/assign
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 22, 2020
@zanhsieh
Copy link
Collaborator

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atkrad, zanhsieh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Jul 22, 2020
@k8s-ci-robot k8s-ci-robot merged commit d28702c into helm:master Jul 22, 2020
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
…1.13 (helm#23299)

* [stable/prometheus] Disable "enableServiceLinks" on Kubernetes prior 1.13

Signed-off-by: Mohammad Abdolirad <[email protected]>

* [stable/prometheus] Chart Version bumped

Signed-off-by: Mohammad Abdolirad <[email protected]>
Signed-off-by: Adrien Loiseau <[email protected]>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
…1.13 (helm#23299)

* [stable/prometheus] Disable "enableServiceLinks" on Kubernetes prior 1.13

Signed-off-by: Mohammad Abdolirad <[email protected]>

* [stable/prometheus] Chart Version bumped

Signed-off-by: Mohammad Abdolirad <[email protected]>
Signed-off-by: Miguel Mingorance <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants