-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/prometheus] Disable "enableServiceLinks" on Kubernetes prior 1.13 #23299
Conversation
…1.13 Signed-off-by: Mohammad Abdolirad <[email protected]>
Signed-off-by: Mohammad Abdolirad <[email protected]>
Hi @atkrad. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atkrad, zanhsieh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…1.13 (helm#23299) * [stable/prometheus] Disable "enableServiceLinks" on Kubernetes prior 1.13 Signed-off-by: Mohammad Abdolirad <[email protected]> * [stable/prometheus] Chart Version bumped Signed-off-by: Mohammad Abdolirad <[email protected]> Signed-off-by: Adrien Loiseau <[email protected]>
…1.13 (helm#23299) * [stable/prometheus] Disable "enableServiceLinks" on Kubernetes prior 1.13 Signed-off-by: Mohammad Abdolirad <[email protected]> * [stable/prometheus] Chart Version bumped Signed-off-by: Mohammad Abdolirad <[email protected]> Signed-off-by: Miguel Mingorance <[email protected]>
What this PR does / why we need it:
I use K8s prior 1.13 when I've applied the Prometheus statefulset this error occurred:
Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: ValidationError(StatefulSet.spec.template.spec): unknown field "enableServiceLinks" in io.k8s.api.core.v1.PodSpec
because the field doesn't available for prior version 1.13
Which issue this PR fixes
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname]
)