Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/prometheus-mongodb-exporter] Add ServiceMonitor metricRelabeling #23290

Merged
merged 1 commit into from
Jul 27, 2020
Merged

[stable/prometheus-mongodb-exporter] Add ServiceMonitor metricRelabeling #23290

merged 1 commit into from
Jul 27, 2020

Conversation

calvinbui
Copy link
Contributor

Signed-off-by: Calvin Bui [email protected]

What this PR does / why we need it:

Adds the ServiceMonitor metricRelabelings key as documented in the Prometheus Operator API.

Used for adding, dropping or renaming labels at ingestion time, or to drop entire metrics that are not useful.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 22, 2020
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 22, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @calvinbui. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@calvinbui
Copy link
Contributor Author

/assign @steven-sheehy

@calvinbui
Copy link
Contributor Author

hey @steven-sheehy a gentle bump

steven-sheehy
steven-sheehy approved these changes Jul 27, 2020
View reviewed changes
Copy link
Collaborator

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 27, 2020
@steven-sheehy
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: calvinbui, steven-sheehy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2020
@k8s-ci-robot k8s-ci-robot merged commit e7b9c26 into helm:master Jul 27, 2020
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
@calvinbui @li-adrienloiseau
[stable/prometheus-mongodb-exporter] Add ServiceMonitor metricRelabel…
17b3cf9 
…ings (helm#23290)

Signed-off-by: Calvin Bui <[email protected]>
Signed-off-by: Adrien Loiseau <[email protected]>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@calvinbui
[stable/prometheus-mongodb-exporter] Add ServiceMonitor metricRelabel…
2668bfb 
…ings (helm#23290)

Signed-off-by: Calvin Bui <[email protected]>
Signed-off-by: Miguel Mingorance <[email protected]>
@calvinbui calvinbui mentioned this pull request Dec 21, 2020
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steven-sheehy steven-sheehy steven-sheehy approved these changes

@prydonius prydonius Awaiting requested review from prydonius

Assignees

@steven-sheehy steven-sheehy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@calvinbui @k8s-ci-robot @steven-sheehy @helm-bot