-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/airflow] Allowing for specifying a NodePort number for Flower #23244
Conversation
Hi @alexbegg. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @thesuperzapper |
@alexbegg: GitHub didn't allow me to assign the following users: thesuperzapper. Note that only helm members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@gsemet @thesuperzapper @maver1ck anyone want to review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the version thing, looks good.
Signed-off-by: Alex Begg <[email protected]>
thanks for the PR and for review ! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexbegg, gsemet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…helm#23244) Signed-off-by: Alex Begg <[email protected]> Signed-off-by: Adrien Loiseau <[email protected]>
…helm#23244) Signed-off-by: Alex Begg <[email protected]> Signed-off-by: Miguel Mingorance <[email protected]>
What this PR does / why we need it:
There previously was no way to specify a port when using the NodePort service type for Flower, this adds that ability. Adding in the NodePort values the same exact way it is provided for Web. Also changing the multiple
if
lines to a single line.There was no reason to change the README because it just lists
flower.service.*
and then says<see values.yaml>
.Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname]
)