Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/prometheus-operator] Add volume mounts and volume #23047

Merged
merged 2 commits into from
Jul 22, 2020
Merged

[stable/prometheus-operator] Add volume mounts and volume #23047

merged 2 commits into from
Jul 22, 2020

Conversation

omerlh
Copy link
Contributor

@omerlh omerlh commented Jul 2, 2020 •
edited
Loading

What this PR does / why we need it:

Which issue this PR fixes

Added volume mounts and volume to alert manager spec

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 2, 2020
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 2, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @omerlh. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 2, 2020
vsliouniaev
vsliouniaev approved these changes Jul 15, 2020
View reviewed changes
Copy link
Collaborator

@vsliouniaev vsliouniaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. ok-to-test lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 15, 2020
@vsliouniaev
Copy link
Collaborator

Could you please bump the chart version

@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2020
@omerlh
Copy link
Contributor Author

omerlh commented Jul 22, 2020

Fixed, thanks :)

@vsliouniaev
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: omerlh, vsliouniaev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 76982a5 into helm:master Jul 22, 2020
@omerlh omerlh deleted the patch-3 branch July 22, 2020 09:54
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
@omerlh @li-adrienloiseau
prometheus-operator/added volumeMounts and volume (helm#23047)
fb454a7 
Signed-off-by: omerlh <[email protected]>
Signed-off-by: Adrien Loiseau <[email protected]>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@omerlh
prometheus-operator/added volumeMounts and volume (helm#23047)
b574260 
Signed-off-by: omerlh <[email protected]>
Signed-off-by: Miguel Mingorance <[email protected]>
@BryanEllington BryanEllington mentioned this pull request Aug 29, 2020
Closed
@BryanEllington BryanEllington mentioned this pull request Sep 28, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vsliouniaev vsliouniaev vsliouniaev approved these changes

@bismarck bismarck Awaiting requested review from bismarck

@gianrubio gianrubio Awaiting requested review from gianrubio

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@omerlh @k8s-ci-robot @vsliouniaev @helm-bot