Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[Stable/rethinkdb] Fix rethinkdb cluster ip field is immutable #22818

Merged
merged 1 commit into from
Jul 18, 2020
Merged

[Stable/rethinkdb] Fix rethinkdb cluster ip field is immutable #22818

merged 1 commit into from
Jul 18, 2020

Conversation

junchil
Copy link
Contributor

@junchil junchil commented Jun 16, 2020

Signed-off-by: junchil [email protected]

Is this a new chart

No

What this PR does / why we need it:

Bug fix

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 16, 2020
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 16, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @junchil. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@junchil
Copy link
Contributor Author

junchil commented Jun 16, 2020

/assign @sameersbn

@stale
Copy link

stale bot commented Jul 18, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 18, 2020
@davidkarlsen
Copy link
Member

/ok-to-test
/assign

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 18, 2020
@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 18, 2020
@davidkarlsen
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidkarlsen, junchil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit b8725a1 into helm:master Jul 18, 2020
includerandom pushed a commit to includerandom/helm_charts that referenced this pull request Jul 19, 2020
@junchil @includerandom
[Stable/rethinkdb] Fix rethinkdb cluster ip field is immutable (helm#…
4394496 
…22818)

Signed-off-by: junchil <[email protected]>
KinsheX pushed a commit to KinsheX/charts that referenced this pull request Jul 20, 2020
@junchil @KinsheX
[Stable/rethinkdb] Fix rethinkdb cluster ip field is immutable (helm#…
94ea6bd 
…22818)

Signed-off-by: junchil <[email protected]>
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
@junchil @li-adrienloiseau
[Stable/rethinkdb] Fix rethinkdb cluster ip field is immutable (helm#…
2913cfa 
…22818)

Signed-off-by: junchil <[email protected]>
Signed-off-by: Adrien Loiseau <[email protected]>
@junchil junchil deleted the fix-rethinkdb branch August 6, 2020 10:37
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@junchil
[Stable/rethinkdb] Fix rethinkdb cluster ip field is immutable (helm#…
4f2a702 
…22818)

Signed-off-by: junchil <[email protected]>
Signed-off-by: Miguel Mingorance <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sameersbn sameersbn Awaiting requested review from sameersbn

@unguiculus unguiculus Awaiting requested review from unguiculus

Assignees

@davidkarlsen davidkarlsen

@sameersbn sameersbn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[stable/rethinkdb] invalid: spec.clusterIP: Invalid value: "": field is immutable
5 participants
@junchil @k8s-ci-robot @davidkarlsen @sameersbn @helm-bot