-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[incubator/druid] upgrade dependencies to latest version #22755
Conversation
Signed-off-by: slyao <[email protected]>
Signed-off-by: slyao <[email protected]>
Signed-off-by: slyao <[email protected]>
Hi @AWaterColorPen. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@AWaterColorPen: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @maver1ck |
/ok-to-test |
I had tested the PR on my k8s cluster. it was ok. And I checked the e2e test log, it seems zookeeper headless service issue. /retest |
/retest |
@AWaterColorPen |
@maver1ck let me add a new commit to revert ZK. |
Signed-off-by: slyao <[email protected]>
Signed-off-by: slyao <[email protected]>
/ok-to-test |
I checked the last e2e test's log.
|
/test pull-charts-e2e |
I can't understand why it failed when just get
I checked the jobs after We should hold this PR and wait CI to be healthy 😂 |
/test pull-charts-e2e |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AWaterColorPen, maver1ck The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@AWaterColorPen |
@AWaterColorPen Thanks a lot. |
* upgrade requirements dependencies chart package to latest version Signed-off-by: slyao <[email protected]> * add awatercolorpen to maintainers and onwers and update chart version Signed-off-by: slyao <[email protected]> * fix name Signed-off-by: slyao <[email protected]> * revert zk version Signed-off-by: slyao <[email protected]> * try to fix e2e test by zk 2.1.4 new feature Signed-off-by: slyao <[email protected]> Co-authored-by: slyao <[email protected]> Signed-off-by: camelusluo <[email protected]>
* upgrade requirements dependencies chart package to latest version Signed-off-by: slyao <[email protected]> * add awatercolorpen to maintainers and onwers and update chart version Signed-off-by: slyao <[email protected]> * fix name Signed-off-by: slyao <[email protected]> * revert zk version Signed-off-by: slyao <[email protected]> * try to fix e2e test by zk 2.1.4 new feature Signed-off-by: slyao <[email protected]> Co-authored-by: slyao <[email protected]>
* upgrade requirements dependencies chart package to latest version Signed-off-by: slyao <[email protected]> * add awatercolorpen to maintainers and onwers and update chart version Signed-off-by: slyao <[email protected]> * fix name Signed-off-by: slyao <[email protected]> * revert zk version Signed-off-by: slyao <[email protected]> * try to fix e2e test by zk 2.1.4 new feature Signed-off-by: slyao <[email protected]> Co-authored-by: slyao <[email protected]>
* upgrade requirements dependencies chart package to latest version Signed-off-by: slyao <[email protected]> * add awatercolorpen to maintainers and onwers and update chart version Signed-off-by: slyao <[email protected]> * fix name Signed-off-by: slyao <[email protected]> * revert zk version Signed-off-by: slyao <[email protected]> * try to fix e2e test by zk 2.1.4 new feature Signed-off-by: slyao <[email protected]> Co-authored-by: slyao <[email protected]> Signed-off-by: Adrien Loiseau <[email protected]>
* upgrade requirements dependencies chart package to latest version Signed-off-by: slyao <[email protected]> * add awatercolorpen to maintainers and onwers and update chart version Signed-off-by: slyao <[email protected]> * fix name Signed-off-by: slyao <[email protected]> * revert zk version Signed-off-by: slyao <[email protected]> * try to fix e2e test by zk 2.1.4 new feature Signed-off-by: slyao <[email protected]> Co-authored-by: slyao <[email protected]> Signed-off-by: Miguel Mingorance <[email protected]>
@scottrigby |
@scottrigby could you help to add me as collaborator? |
Hi, @scottrigby @AWaterColorPen . Is there any threshold for becoming a Collaborator? Currently, I have also contributed some PRs to the incubator/druid chart. I am also the Committer & PMC of Apache Druid. I wonder if I can also be added as a Collaborator for this chart? 😄 |
@AWaterColorPen added you per https://github.com/helm/charts#owning-and-maintaining-a-chart @asdf2014 In general we look for a history of past contributions. I see you have done that https://github.com/helm/charts/commits?author=asdf2014. You would want to make a PR to add you to the chart.yaml maintainers list and chart OWNERS file, and use the PR to discuss with the current maintainers for adding you. One note, have you seen #23685 (comment)? |
@scottrigby Thanks for your reply, a PR has been created as required. In addition, regarding the migration you mentioned, given that we have maintained a druid-operator project separately, I also think it is unlikely that this chart will be migrated to the current Apache Druid code. |
@asdf2014 For my understanding, druid-operator is not a helm chart project. right? |
@AWaterColorPen Yes, your understanding is correct. |
Is this a new chart
What this PR does / why we need it:
zookeeper
from2.1.3
to2.1.4
0e247de#diff-a98ea5ed3d7475f31d22d53b4e07e244 enable the new feature to fix zk pod crash issue.
mysql
from0.10.2
to1.6.4
postgresql
from3.11.7
to8.6.4
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname]
)