Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[incubator/druid] upgrade dependencies to latest version #22755

Merged
merged 5 commits into from
Jun 13, 2020
Merged

[incubator/druid] upgrade dependencies to latest version #22755

merged 5 commits into from
Jun 13, 2020

Conversation

AWaterColorPen
Copy link
Collaborator

@AWaterColorPen AWaterColorPen commented Jun 11, 2020

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 11, 2020
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 11, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @AWaterColorPen. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AWaterColorPen
Copy link
Collaborator Author

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@AWaterColorPen: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AWaterColorPen
Copy link
Collaborator Author

/assign @maver1ck
please help for a review.

@maver1ck
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 11, 2020
@AWaterColorPen
Copy link
Collaborator Author

AWaterColorPen commented Jun 11, 2020

I had tested the PR on my k8s cluster. it was ok. And I checked the e2e test log, it seems zookeeper headless service issue.

/retest

@maver1ck
Copy link
Collaborator

/retest

@maver1ck
Copy link
Collaborator

@AWaterColorPen
Maybe let's try without upgrade of ZK ?

@AWaterColorPen
Copy link
Collaborator Author

AWaterColorPen commented Jun 11, 2020

@maver1ck let me add a new commit to revert ZK.
but I had checked ZK change 0e247de#diff-a98ea5ed3d7475f31d22d53b4e07e244
There is no real critical change.

@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2020
@helm-bot helm-bot removed the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Jun 11, 2020
Signed-off-by: slyao <[email protected]>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Jun 11, 2020
@maver1ck
Copy link
Collaborator

/ok-to-test

@AWaterColorPen
Copy link
Collaborator Author

I checked the last e2e test's log.

I0611 12:43:09.283]   Warning  Unhealthy  2m27s (x4 over 3m6s)  kubelet, gke-jenkins-default-pool-51cafeba-1lzf  Liveness probe errored: rpc error: code = Unknown desc = Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
I0611 12:43:09.284]   Warning  Unhealthy  2m18s                 kubelet, gke-jenkins-default-pool-51cafeba-1lzf  Readiness probe errored: rpc error: code = Unknown desc = error during connect: Get http://%2Fvar%2Frun%2Fdocker.sock/containers/916aca5088a6ee2576ae7ef46721c09eebd6859166e6286c43e5c1728aa92848/json: read unix @->/var/run/docker.sock: read: connection reset by peer
I0611 12:43:09.284]   Warning  Unhealthy  2m18s                 kubelet, gke-jenkins-default-pool-51cafeba-1lzf  Readiness probe errored: rpc error: code = Unknown desc = Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
I0611 12:43:09.298] ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
I0611 12:43:09.298] <== Description of pod druid-jkg1brtxoo-zookeeper-0
I0611 12:43:09.300] ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
I0611 12:43:10.414] ------------------------------------------------------------------------------------------------------------------------
I0611 12:43:10.414] ==> Logs of container druid-jkg1brtxoo-zookeeper-0
I0611 12:43:10.415] ------------------------------------------------------------------------------------------------------------------------
I0611 12:45:10.257] ------------------------------------------------------------------------------------------------------------------------
I0611 12:45:10.258] <== Logs of container druid-jkg1brtxoo-zookeeper-0
I0611 12:45:10.259] ------------------------------------------------------------------------------------------------------------------------

Unknown desc = Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running. It seems zookeeper-0's node is unhealthy, then zookeeper-1 can't find zookeeper-0 any more. 😰 Maybe we can try retest again.

@AWaterColorPen
Copy link
Collaborator Author

/test pull-charts-e2e

@AWaterColorPen
Copy link
Collaborator Author

AWaterColorPen commented Jun 11, 2020

I can't understand why it failed when just get ContainerCreating pod status. But it started to pull image at I0611 14:18:06.284😂

I0611 14:18:09.146] Error from server (BadRequest): container "druid" in pod "druid-mjkt0qldfq-coordinator-749bdc4bb4-7fbkq" is waiting to start: ContainerCreating
I0611 14:18:09.147] Error printing details: Error waiting for process: exit status 1

I checked the jobs after 2020-06-10 04:07:03 +0000 UTC on CI. Must of them are failed.
There maybe some wrong with e2e CI.

We should hold this PR and wait CI to be healthy 😂

@AWaterColorPen
Copy link
Collaborator Author

/test pull-charts-e2e

@maver1ck
Copy link
Collaborator

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AWaterColorPen, maver1ck

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Jun 13, 2020
@k8s-ci-robot k8s-ci-robot merged commit b7c5db6 into helm:master Jun 13, 2020
@maver1ck
Copy link
Collaborator

@AWaterColorPen
Thank you for your PR.

@asdf2014
Copy link
Contributor

@AWaterColorPen Thanks a lot.

@AWaterColorPen AWaterColorPen deleted the users/slyao/druid branch June 13, 2020 14:38
camelus0211 pushed a commit to camelus0211/charts that referenced this pull request Jul 6, 2020
* upgrade requirements dependencies chart package to latest version

Signed-off-by: slyao <[email protected]>

* add awatercolorpen to maintainers and onwers and update chart version

Signed-off-by: slyao <[email protected]>

* fix name

Signed-off-by: slyao <[email protected]>

* revert zk version

Signed-off-by: slyao <[email protected]>

* try to fix e2e test by zk 2.1.4 new feature

Signed-off-by: slyao <[email protected]>

Co-authored-by: slyao <[email protected]>
Signed-off-by: camelusluo <[email protected]>
irlevesque pushed a commit to quantopian/charts that referenced this pull request Jul 13, 2020
* upgrade requirements dependencies chart package to latest version

Signed-off-by: slyao <[email protected]>

* add awatercolorpen to maintainers and onwers and update chart version

Signed-off-by: slyao <[email protected]>

* fix name

Signed-off-by: slyao <[email protected]>

* revert zk version

Signed-off-by: slyao <[email protected]>

* try to fix e2e test by zk 2.1.4 new feature

Signed-off-by: slyao <[email protected]>

Co-authored-by: slyao <[email protected]>
includerandom pushed a commit to includerandom/helm_charts that referenced this pull request Jul 19, 2020
* upgrade requirements dependencies chart package to latest version

Signed-off-by: slyao <[email protected]>

* add awatercolorpen to maintainers and onwers and update chart version

Signed-off-by: slyao <[email protected]>

* fix name

Signed-off-by: slyao <[email protected]>

* revert zk version

Signed-off-by: slyao <[email protected]>

* try to fix e2e test by zk 2.1.4 new feature

Signed-off-by: slyao <[email protected]>

Co-authored-by: slyao <[email protected]>
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
* upgrade requirements dependencies chart package to latest version

Signed-off-by: slyao <[email protected]>

* add awatercolorpen to maintainers and onwers and update chart version

Signed-off-by: slyao <[email protected]>

* fix name

Signed-off-by: slyao <[email protected]>

* revert zk version

Signed-off-by: slyao <[email protected]>

* try to fix e2e test by zk 2.1.4 new feature

Signed-off-by: slyao <[email protected]>

Co-authored-by: slyao <[email protected]>
Signed-off-by: Adrien Loiseau <[email protected]>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
* upgrade requirements dependencies chart package to latest version

Signed-off-by: slyao <[email protected]>

* add awatercolorpen to maintainers and onwers and update chart version

Signed-off-by: slyao <[email protected]>

* fix name

Signed-off-by: slyao <[email protected]>

* revert zk version

Signed-off-by: slyao <[email protected]>

* try to fix e2e test by zk 2.1.4 new feature

Signed-off-by: slyao <[email protected]>

Co-authored-by: slyao <[email protected]>
Signed-off-by: Miguel Mingorance <[email protected]>
@AWaterColorPen
Copy link
Collaborator Author

@scottrigby
Added myself as OWNER. And this PR is to volunteer as collaborator per issue #13867
@maver1ck seems to be rarely online anymore

@AWaterColorPen
Copy link
Collaborator Author

@scottrigby
Added myself as OWNER. And this PR is to volunteer as collaborator per issue #13867
@maver1ck seems to be rarely online anymore

@scottrigby could you help to add me as collaborator?

@asdf2014
Copy link
Contributor

Hi, @scottrigby @AWaterColorPen . Is there any threshold for becoming a Collaborator? Currently, I have also contributed some PRs to the incubator/druid chart. I am also the Committer & PMC of Apache Druid. I wonder if I can also be added as a Collaborator for this chart? 😄

@scottrigby
Copy link
Member

@AWaterColorPen added you per https://github.com/helm/charts#owning-and-maintaining-a-chart

@asdf2014 In general we look for a history of past contributions. I see you have done that https://github.com/helm/charts/commits?author=asdf2014. You would want to make a PR to add you to the chart.yaml maintainers list and chart OWNERS file, and use the PR to discuss with the current maintainers for adding you.

One note, have you seen #23685 (comment)?

@asdf2014
Copy link
Contributor

@scottrigby Thanks for your reply, a PR has been created as required. In addition, regarding the migration you mentioned, given that we have maintained a druid-operator project separately, I also think it is unlikely that this chart will be migrated to the current Apache Druid code.

@AWaterColorPen
Copy link
Collaborator Author

@asdf2014 For my understanding, druid-operator is not a helm chart project. right?

@asdf2014
Copy link
Contributor

@AWaterColorPen Yes, your understanding is correct.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
6 participants