Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/prometheus-operator] Added supports of ServiceAccount annotation in alertmanager #22725

Merged
merged 2 commits into from
Jun 16, 2020
Merged

[stable/prometheus-operator] Added supports of ServiceAccount annotation in alertmanager #22725

merged 2 commits into from
Jun 16, 2020

Conversation

pburgisser
Copy link
Contributor

@pburgisser pburgisser commented Jun 9, 2020 •
edited
Loading

Signed-off-by: Philippe Bürgisser (Camptocamp) [email protected]

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 9, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @pburgisser-c2c. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 9, 2020
Added supports of ServiceAccount annotation in alertmanager
38216d0 
Signed-off-by: Philippe Bürgisser (Camptocamp) <[email protected]>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Jun 9, 2020
@pburgisser
Copy link
Contributor Author

/assign @gianrubio

vsliouniaev
vsliouniaev approved these changes Jun 9, 2020
View reviewed changes
Copy link
Collaborator

@vsliouniaev vsliouniaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 9, 2020
@pburgisser
Copy link
Contributor Author

/retest

1 similar comment
@pburgisser
Copy link
Contributor Author

/retest

@pburgisser
Copy link
Contributor Author

Hello @vsliouniaev,

Is the test broken ? It's producing a timeout.
I'm not sure if it's the test iteself or my work.

Thanks

@vsliouniaev
Copy link
Collaborator

/retest

@vsliouniaev
Copy link
Collaborator

The test cluster is in a bad state and constantly breaks. There's nothing I can really do about it.

@pburgisser
Copy link
Contributor Author

/retest

1 similar comment
@pburgisser
Copy link
Contributor Author

/retest

@pburgisser
Copy link
Contributor Author

/restest

@pburgisser
Copy link
Contributor Author

/retest

1 similar comment
@pburgisser
Copy link
Contributor Author

/retest

@zanhsieh zanhsieh mentioned this pull request Jun 15, 2020
Merged
4 tasks
@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2020
@scottrigby
Copy link
Member

Resolved merge conflicts in order to retest fixed ci infra
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pburgisser-c2c, scottrigby, vsliouniaev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit aae589f into helm:master Jun 16, 2020
@zanhsieh zanhsieh mentioned this pull request Jun 19, 2020
Merged
4 tasks
camelus0211 pushed a commit to camelus0211/charts that referenced this pull request Jul 6, 2020
@pburgisser @scottrigby
Added supports of ServiceAccount annotation in alertmanager (helm#22725)
fe0a011 
Signed-off-by: Philippe Bürgisser (Camptocamp) <[email protected]>

Co-authored-by: Scott Rigby <[email protected]>
Signed-off-by: camelusluo <[email protected]>
irlevesque pushed a commit to quantopian/charts that referenced this pull request Jul 13, 2020
@pburgisser @scottrigby
Added supports of ServiceAccount annotation in alertmanager (helm#22725)
c3896fc 
Signed-off-by: Philippe Bürgisser (Camptocamp) <[email protected]>

Co-authored-by: Scott Rigby <[email protected]>
includerandom pushed a commit to includerandom/helm_charts that referenced this pull request Jul 19, 2020
@pburgisser @scottrigby @includerandom
Added supports of ServiceAccount annotation in alertmanager (helm#22725)
b3753fb 
Signed-off-by: Philippe Bürgisser (Camptocamp) <[email protected]>

Co-authored-by: Scott Rigby <[email protected]>
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
@pburgisser @scottrigby @li-adrienloiseau
Added supports of ServiceAccount annotation in alertmanager (helm#22725)
40f029d 
Signed-off-by: Philippe Bürgisser (Camptocamp) <[email protected]>

Co-authored-by: Scott Rigby <[email protected]>
Signed-off-by: Adrien Loiseau <[email protected]>
@pburgisser pburgisser mentioned this pull request Aug 11, 2020
Closed
4 tasks
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@pburgisser @scottrigby
Added supports of ServiceAccount annotation in alertmanager (helm#22725)
3b317c2 
Signed-off-by: Philippe Bürgisser (Camptocamp) <[email protected]>

Co-authored-by: Scott Rigby <[email protected]>
Signed-off-by: Miguel Mingorance <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vsliouniaev vsliouniaev vsliouniaev approved these changes

@bismarck bismarck Awaiting requested review from bismarck

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pburgisser @k8s-ci-robot @vsliouniaev @scottrigby @helm-bot