[stable/prometheus-operator] make kube-apiserver-slos configurable via defaultRules.rules.kubeApiserverSlos

[k3a]

Is this a new chart

no

What this PR does / why we need it:

It makes kube-apiserver-slos Prometheus rule configurable like other similar rules. This rule is always firing on the hosted cluster I use, probably because higher latency of apiserver and there is no way to turn off this rule without turning off all the default rules (which I obviously don't want to do).

Which issue this PR fixes

none

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• DCO signed
• Chart Version bumped
• Variables are documented in the README.md
• Title of the PR starts with chart name (e.g. [stable/mychartname])

[k8s-ci-robot]

Hi @k3a. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vsliouniaev]

Rules are sourced from upstream repos and are not configurable in this chart as a result, as doing so would be too complex to manage.

Suggest you look at the upstream jsonnet approach if you need customization or extract the rules from here into your own customisations.

/hold

[k3a]

Yes, they are sourced from upstream but then filtered via condition_map in the sync_prometheus_rules.py. In the README.md you can see lots of similar conditions:

Parameter	Description	Default
defaultRules.create	Create default rules for monitoring the cluster	true
defaultRules.rules.PrometheusOperator	Create Prometheus Operator default rules	true
defaultRules.rules.alertmanager	Create default rules for Alert Manager	true
defaultRules.rules.etcd	Create default rules for ETCD	true
defaultRules.rules.general	Create General default rules	true
defaultRules.rules.k8s	Create K8S default rules	true
defaultRules.rules.kubeApiserver	Create Api Server default rules	true
defaultRules.rules.kubeApiserverError	Create Api Server Error default rules	true
defaultRules.rules.kubePrometheusNodeAlerting	Create Node Alerting default rules	true
defaultRules.rules.kubePrometheusNodeRecording	Create Node Recording default rules	true
defaultRules.rules.kubeScheduler	Create Kubernetes Scheduler default rules	true
defaultRules.rules.kubernetesAbsent	Create Kubernetes Absent (example API Server down) default rules	true
defaultRules.rules.kubernetesApps	Create Kubernetes Apps default rules	true
defaultRules.rules.kubernetesResources	Create Kubernetes Resources default rules	true
defaultRules.rules.kubernetesStorage	Create Kubernetes Storage default rules	true
defaultRules.rules.kubernetesSystem	Create Kubernetes System default rules	true
defaultRules.rules.network	Create networking default rules	true
defaultRules.rules.node	Create Node default rules	true
defaultRules.rules.prometheus	Create Prometheus default rules	true
defaultRules.rules.time	Create time default rules	true

Especially defaultRules.rules.kubeApiserverError seems to be similar to SLOs and it is even no longer present upstream.

[vsliouniaev]

/hold cancel
/ok-to-test
/lgtm

[k3a]

/retest

[vsliouniaev]

/retest

[vsliouniaev]

@k3a looks like the builds have been fixed, could you bump the chart version?

[vsliouniaev]

/lgtm

[vsliouniaev]

@k3a looks like this needs a version bump

[vsliouniaev]

/lgtm

[vsliouniaev]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k3a, vsliouniaev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• stable/prometheus-operator/OWNERS [vsliouniaev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment