Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Add checksum annotation for secrets rendering #22449

Closed
wants to merge 2 commits into from

Conversation

mrballcb
Copy link
Contributor

Is this a new chart

NO

What this PR does / why we need it:

Adds a "checksum/secrets" checksum annotation to the deployment.

We do daily scheduled deployments to refresh short lived AWS keys. The helm
chart stores AWS keys as kube secrets. When nothing else changes but the AWS keys,
the deployment is not perceived as changed, no new replicaset gets created, and no
pod restart occurs.

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mrballcb
To complete the pull request process, please assign torstenwalter
You can assign the PR to them by writing /assign @torstenwalter in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 19, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @mrballcb. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stale
Copy link

stale bot commented Jun 20, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 20, 2020
@mrballcb mrballcb closed this Jun 22, 2020
@mrballcb mrballcb deleted the cloudwatch-exporter-annotation branch June 22, 2020 22:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stable/prometheus-cloudwatch-exporter Add secrets checksum to deployment annotations
3 participants