Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Always pull latest docker image #1856

Closed
wants to merge 1 commit into from
Closed

Always pull latest docker image #1856

wants to merge 1 commit into from

Conversation

kim0
Copy link
Contributor

@kim0 kim0 commented Aug 25, 2017

No description provided.

@k8s-ci-robot
Copy link
Contributor

Hi @kim0. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 25, 2017
@unguiculus
Copy link
Member

unguiculus commented Aug 25, 2017

Any reason why you want to do this? We should really stay with stable versions.

@unguiculus unguiculus self-assigned this Aug 25, 2017
@kim0
Copy link
Contributor Author

kim0 commented Aug 25, 2017

I had deployed the default 2.0.0, and the autoscaler was breaking with some error relating to the size of my Azure VM. I spent a couple of hours tracking it down, to new code that was merged (that should have solved my problem), but since this was pointing to old docker image, I was still pointing at old code!

Looking at https://hub.docker.com/r/wbuchwalter/kubernetes-acs-engine-autoscaler/tags/ "latest" is really the only tag containing the code that knows about all Azure VM sizes. I am not sure if "latest" by definition is unstable, I am thinking it means latest stable tagged image. In which case, it makes sense to me. If that is not the case, then maybe @wbuchwalter should tag a new docker image and that should be made the default!

@wbuchwalter
Copy link
Contributor

Hello,
latest is unstable indeed. When something is verified and working I tag using SemVer.
The reason this has not been done yet is mainly because I was in vacation for a few weeks with very limited internet access (and still am for a few days).
I will push a new tag when I get back.
Note that PR on this repository also usually take a while to be merged (discussed here #1471), so the new chart will be first available here: wbuchwalter/Kubernetes-acs-engine-autoscaler/tree/master/helm-chart

@mgoodness
Copy link
Contributor

We do not want to default to using latest images. If a user needs to do so, he/she can set it in a values file or on the command line.

@mgoodness mgoodness closed this Sep 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants