Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/cluster-autoscaler] Support fullnameOverride #16837

Merged
merged 2 commits into from
Nov 5, 2019
Merged

[stable/cluster-autoscaler] Support fullnameOverride #16837

merged 2 commits into from
Nov 5, 2019

Conversation

yurrriq
Copy link
Collaborator

@yurrriq yurrriq commented Sep 4, 2019 •
edited
Loading

What this PR does / why we need it:

Support fullnameOverride.

Special notes for your reviewer:

Thoughts, @olemarkus?

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Sep 4, 2019
@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 4, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2019
@yurrriq
Copy link
Collaborator Author

yurrriq commented Sep 4, 2019

/retest

@maorfr
Copy link
Member

maorfr commented Sep 15, 2019

should we add the new field to values.yaml and README.md?

@yurrriq
Copy link
Collaborator Author

yurrriq commented Sep 16, 2019

Sure, good idea. I'll do that now.

@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 16, 2019
@yurrriq
Copy link
Collaborator Author

yurrriq commented Sep 21, 2019

rebased. /ping @maorfr

@maorfr
Copy link
Member

maorfr commented Sep 26, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Sep 26, 2019
@yurrriq
Copy link
Collaborator Author

yurrriq commented Oct 1, 2019

I'll have to rebase again after #17569 is merged.

@yurrriq
Copy link
Collaborator Author

yurrriq commented Oct 23, 2019

rebased again. can you /lgtm again, @maorfr? Thanks!

@yurrriq yurrriq mentioned this pull request Oct 23, 2019
Closed
4 tasks
@maorfr
Copy link
Member

maorfr commented Nov 5, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maorfr, yurrriq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 87034ca into helm:master Nov 5, 2019
@yurrriq yurrriq deleted the cluster-autoscaler-fullname-override branch November 5, 2019 06:44
@yurrriq
Copy link
Collaborator Author

yurrriq commented Nov 5, 2019

Thanks!

hakman pushed a commit to hakman/charts that referenced this pull request Dec 5, 2019
@yurrriq
[stable/cluster-autoscaler] Support fullnameOverride (helm#16837)
bbf900c 
Signed-off-by: Eric Bailey <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maorfr maorfr Awaiting requested review from maorfr

@paulczar paulczar Awaiting requested review from paulczar

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yurrriq @maorfr @k8s-ci-robot @helm-bot