Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/kong] Added PodDisruptionBudget for Kong and its ingress #16293

Merged
merged 4 commits into from
Aug 16, 2019
Merged

[stable/kong] Added PodDisruptionBudget for Kong and its ingress #16293

merged 4 commits into from
Aug 16, 2019

Conversation

felippe-mendonca
Copy link
Contributor

Signed-off-by: Felippe Mendonça [email protected]

What this PR does / why we need it:

In order to prevent unavailability during voluntary disruptions such as node drains, this PR adds PodDisruptionBudget (PDB) objects associated with Kong deployment and its ingress controller.

More details about PDB: https://kubernetes.io/docs/concepts/workloads/pods/disruptions/#how-disruption-budgets-work

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 13, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @felippe-mendonca. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 13, 2019
@felippe-mendonca
Copy link
Contributor Author

/assign @shashiranjan84

hbagdi
hbagdi reviewed Aug 15, 2019
View reviewed changes
stable/kong/values.yaml Outdated
@@ -387,3 +392,7 @@ ingressController:
name:

ingressClass: kong

podDisruptionBudget:
enabled: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set the default to false for both deployments.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@hbagdi
Copy link
Collaborator

hbagdi commented Aug 15, 2019

Please rebase on master.
Once you have disabled the value by default, please update one of the test case to enable PDB to test in CI once.

Thanks!

@hbagdi
Copy link
Collaborator

hbagdi commented Aug 15, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 15, 2019
@felippe-mendonca
Copy link
Contributor Author

lint-charts has failed. Do I need to bump the version? @hbagdi

@hbagdi
Copy link
Collaborator

hbagdi commented Aug 15, 2019

@felippe-mendonca Please rebase on master branch and bump up the version to fix the lint error.

@felippe-mendonca
rebasing upstream
8149c73
@felippe-mendonca
changed default value podDisruption feature to false
1026139 
- update README
- included ci test to podDisruptionBudget

Signed-off-by: Felippe Mendonça <[email protected]>
@felippe-mendonca
version bumped
a99755b 
Signed-off-by: Felippe Mendonça <[email protected]>
@hbagdi
Copy link
Collaborator

hbagdi commented Aug 16, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felippe-mendonca, hbagdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2019
@hbagdi
Copy link
Collaborator

hbagdi commented Aug 16, 2019

@felippe-mendonca Thank you for your contribution!

@hbagdi hbagdi mentioned this pull request Aug 16, 2019
Merged
4 tasks
@hbagdi
Copy link
Collaborator

hbagdi commented Aug 16, 2019

/test pull-charts-e2e

@k8s-ci-robot k8s-ci-robot merged commit 7adb8ee into helm:master Aug 16, 2019
ThoTischner pushed a commit to bitsbeats/charts that referenced this pull request Aug 19, 2019
@felippe-mendonca
[stable/kong] Added PodDisruptionBudget for Kong and its ingress (hel…
1c26083 
…m#16293)

* added PodDisruptionBudget on Kong and its ingress

Signed-off-by: Felippe Mendonça <[email protected]>

* changed default value podDisruption feature to false
- update README
- included ci test to podDisruptionBudget

Signed-off-by: Felippe Mendonça <[email protected]>

* version bumped

Signed-off-by: Felippe Mendonça <[email protected]>
landorg pushed a commit to landorg/charts that referenced this pull request Aug 19, 2019
@felippe-mendonca @landorg
[stable/kong] Added PodDisruptionBudget for Kong and its ingress (hel…
5f348e8 
…m#16293)

* added PodDisruptionBudget on Kong and its ingress

Signed-off-by: Felippe Mendonça <[email protected]>

* changed default value podDisruption feature to false
- update README
- included ci test to podDisruptionBudget

Signed-off-by: Felippe Mendonça <[email protected]>

* version bumped

Signed-off-by: Felippe Mendonça <[email protected]>
Signed-off-by: Roland Gritzer <[email protected]>
kengou pushed a commit to kengou/charts that referenced this pull request Sep 18, 2019
@felippe-mendonca @kengou
[stable/kong] Added PodDisruptionBudget for Kong and its ingress (hel…
5570ccf 
…m#16293)

* added PodDisruptionBudget on Kong and its ingress

Signed-off-by: Felippe Mendonça <[email protected]>

* changed default value podDisruption feature to false
- update README
- included ci test to podDisruptionBudget

Signed-off-by: Felippe Mendonça <[email protected]>

* version bumped

Signed-off-by: Felippe Mendonça <[email protected]>
ramkumarvs pushed a commit to yugabyte/charts-helm-fork that referenced this pull request Sep 30, 2019
@felippe-mendonca
[stable/kong] Added PodDisruptionBudget for Kong and its ingress (hel…
33cca17 
…m#16293)

* added PodDisruptionBudget on Kong and its ingress

Signed-off-by: Felippe Mendonça <[email protected]>

* changed default value podDisruption feature to false
- update README
- included ci test to podDisruptionBudget

Signed-off-by: Felippe Mendonça <[email protected]>

* version bumped

Signed-off-by: Felippe Mendonça <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hbagdi hbagdi hbagdi left review comments

@shashiranjan84 shashiranjan84 Awaiting requested review from shashiranjan84

Assignees

@shashiranjan84 shashiranjan84

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@felippe-mendonca @k8s-ci-robot @hbagdi @shashiranjan84 @helm-bot