-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/fluent-bit] feature - add support for lua filter #15776
Conversation
- add option to use Lua filters
the flag `parsers.enabled` has to be set to include the final parsers.conf in [daemonset.yaml](https://github.com/helm/charts/blob/master/stable/fluent-bit/templates/daemonset.yaml#L95)
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: daniel-ciaglia The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @daniel-ciaglia. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @Towmeykaw |
@@ -14,7 +14,6 @@ data: | |||
Flush {{ .Values.service.flush }} | |||
Daemon Off | |||
Log_Level {{ .Values.service.logLevel }} | |||
Parsers_File parsers.conf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the ramification of this being removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the PR #15775 for details on that.
as this is new fuctionality
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
This issue is being automatically closed due to inactivity. |
:( |
@daniel-ciaglia @kfox1111 What was happening with this pull-request? |
Perhaps @daniel-ciaglia should re-open it |
Hi @hectorj2f, I don't have the option available to re-open the PR. |
What this PR does / why we need it:
Fluent Bit supports Lua as Filter. I enabled that feature in this chart - see the fluent-bit documentation
The Lua script is provided as
raw
data as shown below and must be referenced asextra.lua
in the FILTERThe filter can then be configured like this:
Special notes for your reviewer:
This PR already incorporates PR #15775
Please check @kfox1111, @edsiper, @hectorj2f
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/chart]
)