Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/fluent-bit] feature - add support for lua filter #15776

Closed
wants to merge 7 commits into from
Closed

[stable/fluent-bit] feature - add support for lua filter #15776

wants to merge 7 commits into from

Conversation

daniel-ciaglia
Copy link

What this PR does / why we need it:

Fluent Bit supports Lua as Filter. I enabled that feature in this chart - see the fluent-bit documentation

The Lua script is provided as raw data as shown below and must be referenced as extra.lua in the FILTER

filter:
  lua:
    enabled: true
    raw: |-
    # example callback
      function cb_print(tag, timestamp, record)
        return code, timestamp, record
      end

The filter can then be configured like this:

rawConfig: |
  @INCLUDE fluent-bit-service.conf
  @INCLUDE fluent-bit-input.conf
  @INCLUDE fluent-bit-filter.conf
  [FILTER]
      Name    lua
      Match   *
      script  extra.lua
      call    cb_print
  @INCLUDE fluent-bit-output.conf

Special notes for your reviewer:

This PR already incorporates PR #15775
Please check @kfox1111, @edsiper, @hectorj2f

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

Daniel Ciaglia added 5 commits July 22, 2019 17:24
- add option to use Lua filters
the flag `parsers.enabled` has to be set to include the final parsers.conf in [daemonset.yaml](https://github.com/helm/charts/blob/master/stable/fluent-bit/templates/daemonset.yaml#L95)
- bump version
- re-order lua settings
@helm-bot helm-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 23, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: daniel-ciaglia
To complete the pull request process, please assign towmeykaw
You can assign the PR to them by writing /assign @towmeykaw in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 23, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @daniel-ciaglia. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@daniel-ciaglia
Copy link
Author

/assign @Towmeykaw

@@ -14,7 +14,6 @@ data:
Flush {{ .Values.service.flush }}
Daemon Off
Log_Level {{ .Values.service.logLevel }}
Parsers_File parsers.conf
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the ramification of this being removed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the PR #15775 for details on that.

as this is new fuctionality
@stale
Copy link

stale bot commented Aug 23, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 23, 2019
@stale
Copy link

stale bot commented Sep 6, 2019

This issue is being automatically closed due to inactivity.

@stale stale bot closed this Sep 6, 2019
@Allex1
Copy link

Allex1 commented Oct 3, 2019

:(

@khauser
Copy link
Contributor

khauser commented Feb 21, 2020

@daniel-ciaglia @kfox1111 What was happening with this pull-request?

@daniel-ciaglia
Copy link
Author

@khauser @kfox1111 - nothing happend from my side to this PR.
We're using internal clones of the charts for now with the proposed changes applied.

@hectorj2f
Copy link
Collaborator

Perhaps @daniel-ciaglia should re-open it

@daniel-ciaglia
Copy link
Author

Hi @hectorj2f, I don't have the option available to re-open the PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants