Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Mysql exporter managing labels #15349

Merged
merged 3 commits into from
Jul 9, 2019
Merged

Mysql exporter managing labels #15349

merged 3 commits into from
Jul 9, 2019

Conversation

Zempashi
Copy link
Contributor

@Zempashi Zempashi commented Jul 9, 2019 •
edited
Loading

What this PR does / why we need it:

Help managing label for serviceMonitor in stable/prometheus-mysql-exporter

Special notes for your reviewer:

Add some missing docs about newly introduced servicemonitor

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 9, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 9, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @Zempashi. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Zempashi
Copy link
Contributor Author

Zempashi commented Jul 9, 2019

/assign @monotek

@Zempashi
Copy link
Contributor Author

Zempashi commented Jul 9, 2019

https://github.com/coreos/prometheus-operator/blob/master/Documentation/api.md#servicemonitor could be useful to review changes

@monotek
Copy link
Collaborator

monotek commented Jul 9, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: monotek, Zempashi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2019
@k8s-ci-robot k8s-ci-robot merged commit 1fec99c into helm:master Jul 9, 2019
ThoTischner pushed a commit to bitsbeats/charts that referenced this pull request Aug 13, 2019
@Zempashi
Mysql exporter managing labels (helm#15349)
a2ae9b4 
* [stable/prometheus-mysql-exporter] Add docs param for servicemonitor

Signed-off-by: Julien Girardin <[email protected]>

* [stable/prometheus-mysql-exporter] Add serviceMonitor labels management

Signed-off-by: Julien Girardin <[email protected]>

* [stable/prometheus-mysql-exporter] Bump chart version to 0.5.1

Signed-off-by: Julien Girardin <[email protected]>
@Aaron-ML Aaron-ML mentioned this pull request Oct 23, 2019
Closed
@AlexDCraig AlexDCraig mentioned this pull request Mar 10, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@monotek monotek monotek approved these changes

@Juanchimienti Juanchimienti Awaiting requested review from Juanchimienti

Assignees

@monotek monotek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Zempashi @k8s-ci-robot @monotek @helm-bot