Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/redis] Add --no-auth-warning to health checks #15100

Merged
merged 4 commits into from
Jul 3, 2019
Merged

[stable/redis] Add --no-auth-warning to health checks #15100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6be738a
Added --no-auth-warning to redis-cli calls in health-configmap
bbenzikry Jun 27, 2019
1e73c79
update tag for redis-lib-values
bbenzikry Jun 27, 2019
54cd402
bump chart version
bbenzikry Jun 28, 2019
64ebb19
added no-auth-warning flag on top of new probe changes
bbenzikry Jun 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stable/redis/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v1
name: redis
version: 8.0.14
version: 8.0.15
appVersion: 5.0.5
description: Open source, advanced key-value store. It is often referred to as a data structure server since keys can contain strings, hashes, lists, sets and sorted sets.
keywords:
Expand Down
2 changes: 1 addition & 1 deletion stable/redis/ci/redis-lib-values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
image:
registry: docker.io
repository: redis
tag: '4.0.11'
tag: '5.0.5'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo this change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flag is not supported on this version
See https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/helm_charts/15100/pull-charts-e2e/1144314462543548416/build-log.txt

docker://redis-08ug45oq09:Container failed liveness probe.. Container will be killed and recreated.
I0627 19:08:34.757]   Warning  Unhealthy               8m53s (x9 over 9m38s)  kubelet, gke-jenkins-default-pool-51cafeba-f5cd  Liveness probe failed: 
I0627 19:08:34.757] Warning: Using a password with '-a' option on the command line interface may not be safe.
I0627 19:08:34.757] Unrecognized option or bad number of args for: '--no-auth-warning'

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm.. You're right! Skip this comment!


master:
command: "redis-server"
Expand Down
10 changes: 5 additions & 5 deletions stable/redis/templates/health-configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ data:
timeout -s 9 $1 \
redis-cli \
{{- if .Values.usePassword }}
-a $REDIS_PASSWORD \
-a $REDIS_PASSWORD --no-auth-warning \
{{- end }}
-h localhost \
-p $REDIS_PORT \
Expand All @@ -36,7 +36,7 @@ data:
timeout -s 9 $1 \
redis-cli \
{{- if .Values.usePassword }}
-a $REDIS_PASSWORD \
-a $REDIS_PASSWORD --no-auth-warning \
{{- end }}
-h localhost \
-p $REDIS_PORT \
Expand All @@ -56,7 +56,7 @@ data:
timeout -s 9 $1 \
redis-cli \
{{- if .Values.usePassword }}
-a $REDIS_PASSWORD \
-a $REDIS_PASSWORD --no-auth-warning \
{{- end }}
-h localhost \
-p $REDIS_SENTINEL_PORT \
Expand Down Expand Up @@ -91,7 +91,7 @@ data:
timeout -s 9 $1 \
redis-cli \
{{- if .Values.usePassword }}
-a $REDIS_MASTER_PASSWORD \
-a $REDIS_MASTER_PASSWORD --no-auth-warning \
{{- end }}
-h $REDIS_MASTER_HOST \
-p $REDIS_MASTER_PORT_NUMBER \
Expand All @@ -110,7 +110,7 @@ data:
timeout -s 9 $1 \
redis-cli \
{{- if .Values.usePassword }}
-a $REDIS_MASTER_PASSWORD \
-a $REDIS_MASTER_PASSWORD --no-auth-warning \
{{- end }}
-h $REDIS_MASTER_HOST \
-p $REDIS_MASTER_PORT_NUMBER \
Expand Down