This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/rabbitmq] Add parameters to limit the number of scheduler threads. #13044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eads. Signed-off-by: juan131 <[email protected]>
helm-bot
added
Contribution Allowed
k8s-ci-robot
added
the
approved
tompizmor
suggested changes
Apr 15, 2019
| {{- if and .Values.rabbitmq.maxAvailableSchedulers }} | ||
| - name: RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS | ||
| value: {{ printf "+S %s:%s" (toString .Values.rabbitmq.maxAvailableSchedulers) (toString .Values.rabbitmq.onlineSchedulers) -}} | ||
| {{- end }} |
There was a problem hiding this comment.
this end tag has no the same indentation that the if one
Signed-off-by: juan131 <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juan131, tompizmor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
TsuyoshiUshio
pushed a commit
to TsuyoshiUshio/charts
that referenced
this pull request
Apr 18, 2019
…eads. (helm#13044) * [stable/rabbitmq] Add parameters to limit the number of scheduler threads. Signed-off-by: juan131 <[email protected]> * Fix indentation Signed-off-by: juan131 <[email protected]>
hajnej
pushed a commit
to hajnej/charts
that referenced
this pull request
Apr 24, 2019
…eads. (helm#13044) * [stable/rabbitmq] Add parameters to limit the number of scheduler threads. Signed-off-by: juan131 <[email protected]> * Fix indentation Signed-off-by: juan131 <[email protected]>
devnulled
pushed a commit
to devnulled/charts
that referenced
this pull request
Apr 25, 2019
…eads. (helm#13044) * [stable/rabbitmq] Add parameters to limit the number of scheduler threads. Signed-off-by: juan131 <[email protected]> * Fix indentation Signed-off-by: juan131 <[email protected]>
dermorz
pushed a commit
to dermorz/charts
that referenced
this pull request
Apr 26, 2019
…eads. (helm#13044) * [stable/rabbitmq] Add parameters to limit the number of scheduler threads. Signed-off-by: juan131 <[email protected]> * Fix indentation Signed-off-by: juan131 <[email protected]>
dpkirchner
pushed a commit
to dpkirchner/charts
that referenced
this pull request
May 9, 2019
…eads. (helm#13044) * [stable/rabbitmq] Add parameters to limit the number of scheduler threads. Signed-off-by: juan131 <[email protected]> * Fix indentation Signed-off-by: juan131 <[email protected]>
goshlanguage
pushed a commit
to goshlanguage/charts
that referenced
this pull request
May 17, 2019
…eads. (helm#13044) * [stable/rabbitmq] Add parameters to limit the number of scheduler threads. Signed-off-by: juan131 <[email protected]> * Fix indentation Signed-off-by: juan131 <[email protected]>
eyenx
pushed a commit
to eyenx/charts
that referenced
this pull request
May 28, 2019
…eads. (helm#13044) * [stable/rabbitmq] Add parameters to limit the number of scheduler threads. Signed-off-by: juan131 <[email protected]> * Fix indentation Signed-off-by: juan131 <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: juan131 [email protected]
What this PR does / why we need it:
RabbitMQ sets the number of threads based on the available CPU cores. Find more information in the link below:
https://hamidreza-s.github.io/erlang/scheduling/real-time/preemptive/migration/2016/02/09/erlang-scheduler-details.html#scheduler-threads
However, on K8s the number of available cores on a K8s node and the amount of CPU assigned to a specific pod can be different.
This PR allows to the user to limit the the number of scheduler threads so RabbitMQ doesn't create too many threads causing high CPU usage.
Which issue this PR fixes
Checklist